Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Many releases get incorrectly renamed (Also see Issue #2609) #2664

@SenTzu01

Description

@SenTzu01

###Expected behaviour
unique ID value of a release stored in DB table release_unique

###Actual behaviour
Same value is stored for many releases

###Steps to reproduce the behaviour
Simply run Tmux with Fix Release Names enabled and PostProcess Additional: All

Cause:
[v0.8.22.0]
nzedb\ReleaseExtra.php line 48:
$uniqueId = (int)$general->get('unique_id')->getShortName();
Method getShortName produces a number value that exceeds PHP Max integer length. Typecasting to int produces an integer overflow resulting in the same integer across releases.
IMHO the value can be stored in the DB as-is (Not typecasted to int).

Fix:
nzedb\ReleaseExtra.php line 48:
$uniqueId = $general->get('unique_id')->getShortName();

also:
if (isset($uniqueId) && strlen($uniqueId) > 1)
provides for better validity checking of shortName in the xml.

This fix seems to produce a unique ID per release allowing individual matching of releases.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions