Uninitialized string copy if move location is empty

**Checklist (Please check before submitting)**

* [x] I reviewed the [Contributing Guide](https://github.com/nasa/DS/blob/main/CONTRIBUTING.md).
* [x] I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

**Describe the bug**
Pathname is only set when move is not empty, but the copy is done outside that condition:
https://github.com/nasa/DS/blob/733b2b269011882c6e1d159bf7c51037f652a405/fsw/src/ds_file.c#L891-L906
https://github.com/nasa/DS/blob/733b2b269011882c6e1d159bf7c51037f652a405/fsw/src/ds_file.c#L968

**To Reproduce**
Produce the packet with move empty

**Expected behavior**
Only copy over if Pathname was set

**System observed on:**
Observed, also flagged by static analysis

**Additional context**
Introduced with file complete tlm packet updates - #39, so doesn't impact draco-rc2

**Reporter Info**
Jacob Hageman - NASA/GSFC

	char PathName[DS_TOTAL_FNAME_BUFSIZE];

	/*
	** First, close the file...
	*/
	OS_close(FileStatus->FileHandle);

	/*
	** Move file only if table has a downlink directory name...
	*/
	if (DS_AppData.DestFileTblPtr->File[FileIndex].Movename[0] != '\0')
	{
	/*
	** Make sure directory name does not end with slash character...
	*/
	strcpy(PathName, DS_AppData.DestFileTblPtr->File[FileIndex].Movename);

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uninitialized string copy if move location is empty #48

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Uninitialized string copy if move location is empty #48

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions