Disallow dimensions and chart being obsolete and archived simultaneously. #9436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://mfundulfix-obsoletion-segfault-tq6nt.squash.io |
thiagoftsm
approved these changes
Jun 28, 2020
Contributor
thiagoftsm
left a comment
There was a problem hiding this comment.
During 10 hours I ran Netdata with the option cleanup obsolete charts after seconds = 30 and I restarted Netdata 7 times, but before to restart it, I always changed the number of dimensions inside the script /usr/libexec/netdata/python.d/example.chart.py to be sure that dimensions would be created in one run and destroyed in the next. During these tests, Netdata never crashed.
stelfrag
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9411
Component Name
database
Test Plan
Affected systems stop crashing with segfault.