Apply LIMIT in getBy* methods #774
Conversation
...extrasTests/Orm/Integration/Relationships/RelationshipManyHasManyTest_testCachingPreload.sql
Show resolved
Hide resolved
src/Collection/DbalCollection.php
Outdated
| { | ||
| return $this->findBy($conds)->fetch(); | ||
| $collection = $this->findBy($conds); | ||
| if (FeatureToggle::$limitInGetBy && $this->connection->getPlatform()->getName() !== SqlServerPlatform::NAME) { |
There was a problem hiding this comment.
The condition on sql platform needs a comment/reasoning.
There was a problem hiding this comment.
Added comment about invalid syntax being generated.
SqlServer might also be supported in theory, but I was not able to do the necessary changes in QueryBuilder - there are more ways how to do it and none of them seems to behave the same as MySQL and PostgreSQL.
I'd suggest to add generated sql files to tests for MySQL and SqlServer before we do so.
There was a problem hiding this comment.
Hey, sorry to bother you once more, but the comment does not add any value - I already knew that you had tried it because it doesn't work. It would be great to add a meaningful example of what does not work or create a ticket and put it there, and put the link into the code... :)
Seeing the wrong SQL it generates everybody exploring the source code will be to "I see, now I understand why it behaves differently" :)
…aneous branch+PR builds
DbalCollection::getBy*(and inherentlyRepository::getBy*) methods applyLIMIT 1UNIQUE.ArrayCollectionbecause it is short-lived in this case and no such change was necessary.Incorrect syntax near 'OFFSET'.). I believe this should be handled in nextras/dbal?Nextras\Orm\FeatureToggle::$limitInGetBy = false;in case it causes any issues. This toggle is planned to be removed in v6.Build changes (that made my life easier):