Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(storage-plugin): mark engine tokens as pure #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2024
Merged

refactor(storage-plugin): mark engine tokens as pure #2249

merged 1 commit into from
Nov 10, 2024

Conversation

arturovt
Copy link
Member

new expressions are considered side-effectful. The /* @__PURE__ */ hint tells the bundler that new InjectionToken has no side effects and that the output of this expression can be safely removed if unused. Therefore, if LOCAL_STORAGE_ENGINE is never used, it can be dropped.

@arturovt
refactor(storage-plugin): mark engine tokens as pure
19a5db7 
`new` expressions are considered side-effectful. The `/* @__PURE__ */` hint tells the bundler
that `new InjectionToken` has no side effects and that the output of this expression can be safely
removed if unused. Therefore, if `LOCAL_STORAGE_ENGINE` is never used, it can be dropped.
@arturovt arturovt force-pushed the refactor/storage-plugin-token branch from a96e948 to 19a5db7 Compare November 10, 2024 12:18
@arturovt arturovt marked this pull request as ready for review November 10, 2024 12:18
@nx-cloud
Copy link

nx-cloud bot commented Nov 10, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 19a5db7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 10, 2024 •
edited
Loading

Open in Stackblitz

@ngxs/devtools-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/form-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/hmr-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/router-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/storage-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/store

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/websocket-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

commit: 19a5db7

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 19a5db7 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.

@bundlemon
Copy link

bundlemon bot commented Nov 10, 2024 •
edited
Loading

BundleMon

Unchanged files (6)
Status Path Size Limits
✅ fesm2022/ngxs-store.mjs
 102.5KB 103KB / +0.5%
✅ fesm2022/ngxs-store-internals.mjs
 11.3KB 13KB / +0.5%
✅ fesm2022/ngxs-store-internals-testing.mjs
 6.83KB 7KB / +0.5%
✅ fesm2022/ngxs-store-operators.mjs
 6.22KB 7KB / +0.5%
✅ fesm2022/ngxs-store-plugins.mjs
 2.04KB 3KB / +0.5%
✅ fesm2022/ngxs-store-experimental.mjs
 1.4KB 2KB / +0.5%

No change in files bundle size

Unchanged groups (2)
Status Path Size Limits
✅ @ngxs/store(esm2022)[gzip]
./esm2022/**/*.mjs
 224.18KB +1%
✅ @ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
 31.13KB +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Nov 10, 2024 •
edited
Loading

BundleMon (NGXS Plugins)

Files updated (1)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
 4.16KB (+15B +0.35%) +0.5%
Unchanged files (8)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
 3.19KB +0.5%
✅ Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
 2.64KB +0.5%
✅ Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
 2.61KB +0.5%
✅ Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
 2.59KB +0.5%
✅ Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
 2.23KB +0.5%
✅ Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
 2.03KB +0.5%
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
 875B +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
 411B +0.5%

Total files change +15B +0.07%

Groups updated (1)
Status Path Size Limits
✅ All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
 20.71KB (+15B +0.07%) +0.5%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Nov 10, 2024 •
edited
Loading

BundleMon (Integration Projects)

Files updated (3)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
 68.53KB (-31B -0.04%) +1%
✅ Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
 67.64KB (-36B -0.05%) +1%
✅ Main bundles(Gzip)
hello-world-ng18/dist-integration/browser/mai
n-(hash).js
 71.68KB (-50B -0.07%) +1%

Total files change -117B -0.05%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@arturovt arturovt merged commit d4388f5 into master Nov 10, 2024
17 of 18 checks passed
@arturovt arturovt deleted the refactor/storage-plugin-token branch November 10, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markwhitfeld markwhitfeld Awaiting requested review from markwhitfeld markwhitfeld is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@arturovt