This repository was archived by the owner on Feb 11, 2022. It is now read-only.
Dependency Update and Solo Exo-player #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update exoplayer to 2.8.4
Allow ExoPlayer implementation to be created with a different DataSource.Factory
Wrap to optional inside new instance method
Add experimental to the build script
rock3r
approved these changes
Sep 27, 2018
zegnus
reviewed
Sep 27, 2018
| String url = request.getDefaultUrl(); | ||
|
|
||
| if (TextUtils.isEmpty(url)) { | ||
| url = mediaProvidedLicenseServerUrl; |
There was a problem hiding this comment.
Rather interestingly I don't think this url is ever used by us. We actually expect a client to pass in the Url as part of the DrmHandler because it's a no-player class rather than an ExoPlayer class.
| } | ||
|
|
||
| private DefaultDataSourceFactory createDataSourceFactory(DefaultBandwidthMeter bandwidthMeter) { | ||
| if (dataSourceFactory.isPresent()) { |
There was a problem hiding this comment.
you can use map, or... not a blocker
zegnus
approved these changes
Sep 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've done a number of changes including:
#177 Update to ExoPlayer 2.8.4
#180 Add experimental deployment to the build script
#181 & #182 Use a custom datasource factory for exoplayer
We want to release these changes as a patch.