fix(core): task-orchestrator properly handles arguments#3560
Merged
juristr merged 1 commit intonrwl:masterfrom Aug 25, 2020
Merged
fix(core): task-orchestrator properly handles arguments#3560juristr merged 1 commit intonrwl:masterfrom
juristr merged 1 commit intonrwl:masterfrom
Conversation
b393ae7 to
5adfa49
Compare
53d34b7 to
5c6f147
Compare
244e56d to
7744dbd
Compare
The task-orchestrator was converting command line flags to "yars-compatible" string using a custom logic. This commit makes sure that this happens through `yargs-unparser` to avoid issues with more complex options like arrays and objects. ISSUES CLOSED: nrwl#3450
Doginal
pushed a commit
to Doginal/nx
that referenced
this pull request
Nov 25, 2020
The task-orchestrator was converting command line flags to "yargs-compatible" string using a custom logic. This commit makes sure that this happens through `yargs-unparser` to avoid issues with more complex options like arrays and objects. ISSUES CLOSED: nrwl#3450
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #3450