Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(storybook): pass on generateCypressSpecs from React storybook schematic#3687

Merged
mandarini merged 1 commit intonrwl:masterfrom
juristr:fix-storybook-react-generatecypressspecs
Sep 8, 2020
Merged

fix(storybook): pass on generateCypressSpecs from React storybook schematic#3687
mandarini merged 1 commit intonrwl:masterfrom
juristr:fix-storybook-react-generatecypressspecs

Conversation

@juristr
Copy link
Member

@juristr juristr commented Sep 8, 2020

Current Behavior

When invoking the configure-storybook schematic from the @nrwl/react package, the generateCypressSpecs didn't get passed along.

image

Expected Behavior

It should get passed along

@juristr juristr marked this pull request as ready for review September 8, 2020 12:19
@juristr juristr requested a review from mandarini September 8, 2020 12:19
Copy link
Contributor

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mandarini mandarini merged commit 18c675a into nrwl:master Sep 8, 2020
@juristr juristr deleted the fix-storybook-react-generatecypressspecs branch September 8, 2020 13:27
Doginal pushed a commit to Doginal/nx that referenced this pull request Nov 25, 2020
@github-actions
Copy link
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants