fix(react): support default envName behavior for babel#3693
Merged
jaysoo merged 1 commit intonrwl:masterfrom Sep 9, 2020
Merged
fix(react): support default envName behavior for babel#3693jaysoo merged 1 commit intonrwl:masterfrom
jaysoo merged 1 commit intonrwl:masterfrom
Conversation
…ugh BABEL_ENV or NODE_ENV)
41a07aa to
537de94
Compare
jaysoo
commented
Sep 9, 2020
| JSON.stringify( | ||
| { | ||
| presets: ['@nrwl/react/babel'], | ||
| plugins: [ |
Member
Author
There was a problem hiding this comment.
Moved it up to the default plugins section since the jest sets NODE_ENV=test, which would override babel envName.
BigAB
approved these changes
Sep 9, 2020
Doginal
pushed a commit
to Doginal/nx
that referenced
this pull request
Nov 25, 2020
…ugh BABEL_ENV or NODE_ENV) (nrwl#3693)
This was referenced Apr 30, 2021
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Cannot use
BABEL_ENVorNODE_ENVto provide babel env -- only through--configuration=.... This is not the normal usage for babel.Expected Behavior
Can set either
BABEL_ENVorNODE_ENV.