fix(repo): tests and e2e, enable linting for workspace to set baseline#3790
Merged
FrozenPandaz merged 3 commits intonrwl:masterfrom Sep 23, 2020
Merged
fix(repo): tests and e2e, enable linting for workspace to set baseline#3790FrozenPandaz merged 3 commits intonrwl:masterfrom
FrozenPandaz merged 3 commits intonrwl:masterfrom
Conversation
Contributor
Nx Cloud ReportCI ran the following commands. Click to see the status, the terminal output, and the build insights.
Sent with 💌 from NxCloud. |
Contributor
Nx Cloud ReportCI ran the following commands. Click to see the status, the terminal output, and the build insights.
Sent with 💌 from NxCloud. |
FrozenPandaz
approved these changes
Sep 23, 2020
Doginal
pushed a commit
to Doginal/nx
that referenced
this pull request
Nov 25, 2020
nrwl#3790) * chore(repo): enable linting for workspace to set baseline * fix(repo): broken tests from master branch * fix(repo): broken e2e tests from master branch
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Master has broken tests and e2e suites introduced by #3766. (This needs further investigation into how this could have happened)
Additionally, linting is not set up for most projects in the Nx workspace (original purpose of PR)
Expected Behavior
All tests and e2e suites should work and linting should be set up for all projects and should run in CI.
Related Issue(s)
As suggested to @FrozenPandaz, it is important that we set up a baseline of linting today before we merge #3763 so that we can appropriately get an idea of before and after, and so that we can dogfood the automated migrations.