fix(misc): allow --js flag to be passed to @nrwl/web:lib schematic#3230
Merged
jaysoo merged 2 commits intonrwl:masterfrom Aug 19, 2020
Merged
fix(misc): allow --js flag to be passed to @nrwl/web:lib schematic#3230jaysoo merged 2 commits intonrwl:masterfrom
jaysoo merged 2 commits intonrwl:masterfrom
Conversation
Member
|
LGTM, but we should add some tests though 🙂 |
|
@BigAB what is the effort on node app to enable |
creates js files instead of ts files s ISSUES CLOSED: nrwl#2985
Member
|
@shreyansh-zazz We need to consider node separately. We're currently addressing the concern in the React community where some developers want to use plain JS rather than TS. You could enable plain JS for node manually by adding |
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Running
nx g @nrwl/web:lib myLib --jsproduces an errorCould not match option 'js' to the @nrwl/web:library schema.Expected Behavior
That running
nx g @nrwl/web:lib myLib --jswould be able to run and generate a web library in js instead of ts.Related Issue(s)
Fixes #2985