-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore(repo): split slow e2e tests #33173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nd affected-graph
…ite-legacy, and web-legacy
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit b2dfdbe
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
The failure was classified as not being a 'code_change' because the error is a formatting issue rather than a functional code problem.
The task outputs show that both gradle-project-graph:build and gradle-project-graph:lint tasks failed with the same error: ktfmt (Kotlin formatter) found that the file /home/workflows/workspace/packages/gradle/project-graph/src/main/kotlin/dev/nx/gradle/data/Dependency.kt is not properly formatted.
The error message states:
[ktfmt] Invalid formatting for: /home/workflows/workspace/packages/gradle/project-graph/src/main/kotlin/dev/nx/gradle/data/Dependency.kt
[ktfmt] Found 1 files that are not properly formatted:
src/main/kotlin/dev/nx/gradle/data/Dependency.kt
After examining the PR diff (which contains 9,793 lines), there are no changes to the packages/gradle/project-graph/src/main/kotlin/dev/nx/gradle/data/Dependency.kt file. The diff includes changes to:
- Workflow configuration files (.nx/workflows/dynamic-changesets.yaml)
- Various e2e test files (cypress, eslint, react, remix, vite, web, webpack)
- Test setup and configuration files
Since the failing file Dependency.kt was not modified in this PR, this is not a failure caused by code changes made in this pull request. This type of failure typically falls into the 'environment_state' category, where pre-existing formatting issues in the codebase were not caught by CI checks before this PR, or the formatting rules have changed, exposing existing non-compliant code. The fix would be to run the ktfmt formatter on the affected file to bring it into compliance with the formatting standards.
A code change would likely not resolve this issue, so no action was taken.
🎓 To learn more about Self Healing CI, please visit nx.dev
…2e-nx This reverts the test splitting changes for the following projects: - e2e-react: Restored cypress-component-tests.test.ts and module-federation tests - e2e-webpack: Restored monolithic webpack.test.ts, removed split test files - e2e-nx: Restored original tsconfig.spec.json These projects were causing slower CI runs, so reverting to their original structure.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #