feat(api,ui): add permission on node and delete permissions on env, app and pipelines#3902
Merged
feat(api,ui): add permission on node and delete permissions on env, app and pipelines#3902
Conversation
added 24 commits
January 21, 2019 11:35
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
golangcibot
reviewed
Feb 1, 2019
There was a problem hiding this comment.
loadWorkflowNodeGroups is unused (from deadcode)
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
richardlt
reviewed
Feb 8, 2019
richardlt
reviewed
Feb 8, 2019
richardlt
reviewed
Feb 8, 2019
richardlt
reviewed
Feb 8, 2019
richardlt
reviewed
Feb 8, 2019
richardlt
reviewed
Feb 8, 2019
richardlt
reviewed
Feb 8, 2019
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
golangcibot
reviewed
Feb 8, 2019
engine/api/migrate/key.go
Outdated
There was a problem hiding this comment.
Error return value of migrateApplication is not checked (from errcheck)
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
richardlt
reviewed
Feb 8, 2019
richardlt
reviewed
Feb 8, 2019
richardlt
reviewed
Feb 8, 2019
richardlt
reviewed
Feb 8, 2019
added 6 commits
February 8, 2019 11:27
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
yesnault
requested changes
Feb 11, 2019
Co-Authored-By: bnjjj <[email protected]>
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
yesnault
approved these changes
Feb 11, 2019
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
richardlt
approved these changes
Feb 11, 2019
added 2 commits
February 11, 2019 15:06
…pp and pipelines Signed-off-by: Benjamin Coenen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
close feature request: improve users mgmnt #3272
close New permission per group or per user #1594
close fix(ui): updating permission of a pipeline #3689
close tests: workflow permissions #2538
close doc: permissions cds workflows #2076
close cdsctl application|pipeline group add|remove|update #2321
@ovh/cds