Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(cdn): remove storage unit #5729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 2, 2021
Merged

feat(cdn): remove storage unit #5729

merged 9 commits into from
Mar 2, 2021

Conversation

@sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Mar 1, 2021

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

richardlt
richardlt requested changes Mar 1, 2021
View reviewed changes
Copy link
Member

@richardlt richardlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think than rather then checking for unit to delete with a ticker and because dropping a unit is not a usual action. It could be better to have a some commands:

  • one to "disable" the unit (off sync, stop loading data from this unit).
  • a another to mark all unit_items to delete.
  • a last one to direct delete the item that fails if there are still unit_items.

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 1, 2021

CDS Report build-all-cds#15665.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 1, 2021

CDS Report build-all-cds#15669.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@sguiheux sguiheux requested a review from richardlt March 1, 2021 13:57
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 1, 2021

CDS Report build-all-cds#15674.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 2, 2021

CDS Report build-all-cds#15674.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

37.9% 37.9% Coverage
0.2% 0.2% Duplication

@sguiheux sguiheux merged commit 9ff91bd into master Mar 2, 2021
@sguiheux sguiheux deleted the disabledCDSBackend branch March 5, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fsamin fsamin fsamin approved these changes

@richardlt richardlt richardlt approved these changes

@yesnault yesnault Awaiting requested review from yesnault yesnault is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sguiheux @ovh-cds @fsamin @richardlt