Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: add stop ticker + time.sleep #5304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2020
Merged

fix: add stop ticker + time.sleep #5304

merged 2 commits into from
Jul 7, 2020

Conversation

@sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Jul 7, 2020

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 7, 2020

CDS Report build-all-cds#13817.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✘
    • Test SDK Rust ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 7, 2020

CDS Report build-all-cds#13817.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package and Analyze
    • Docker ✔
    • Docs ✔
    • Sonar ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘
    • Standalone tests 1 -
    • Standalone tests 2 -
    • Standalone tests 3 -

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@richardlt richardlt merged commit b64bba5 into master Jul 7, 2020
@richardlt richardlt deleted the fixTickerClosed branch July 13, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@richardlt richardlt richardlt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sguiheux @ovh-cds @yesnault @fsamin @richardlt