Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pretty printing of some error for opam source & build actions #6696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2025
Merged

Pretty printing of some error for opam source & build actions #6696

merged 2 commits into from
Sep 19, 2025

Conversation

@rjbou
Copy link
Collaborator

@rjbou rjbou commented Sep 17, 2025 •
edited
Loading

@rjbou rjbou requested a review from kit-ty-kate September 17, 2025 15:29
@rjbou rjbou changed the title Update some error display for opam source & build actions Pretty printing of some error for opam source & build actions Sep 17, 2025
@rjbou rjbou mentioned this pull request Sep 17, 2025
Merged
2 tasks
kit-ty-kate
kit-ty-kate approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I've added the missing changelog item as this changes the behaviour of opam source from a fatal error due to an uncaught exception, to a warning.

I'm not too convinced this should be a warning (i would rather expect an error) but since the other errors were a warning too i think it's fine and it can be changed later if needed. This is orthogonal to the PR.

@kit-ty-kate kit-ty-kate added this to the 2.5.0~alpha1 milestone Sep 17, 2025
@rjbou rjbou added PR: NEEDS UPDATE PR: QUEUED Pending pull request, waiting for other work to be merged or closed and removed PR: NEEDS UPDATE labels Sep 18, 2025
@rjbou
Copy link
Collaborator Author

rjbou commented Sep 19, 2025 •
edited
Loading

On windows

-            - ${BASEDIR}/OPAM/repo/default/packages/escape-absolute/escape-absolute.1/files//etc/passwdd
+            - ${BASEDIR}/OPAM/repo/default/packages/escape-absolute/escape-absolute.1/files/etc/passwdd

The error came from OpamFilename.create. The fix is on #6703

@kit-ty-kate kit-ty-kate removed the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Sep 19, 2025
@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit a9ad523 into ocaml:master Sep 19, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kit-ty-kate kit-ty-kate kit-ty-kate approved these changes

Assignees

No one assigned

Labels

AREA: UI

Projects

None yet

Milestone

2.5.0~alpha1

Development

Successfully merging this pull request may close these issues.

2 participants

@rjbou @kit-ty-kate