Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BUG]: Workflow dispatch events are now suddenly returning 200 for success from the API #1790

@kitallis

Description

@kitallis

What happened?

It seems like this API: https://docs.github.com/en/rest/actions/workflows?apiVersion=2022-11-28#create-a-workflow-dispatch-event is supposed to return 204 for success, but is now returning 200. This breaks actions_workflows code because it relies on boolean_from_response which does not treat a pure 200 as success.

EDIT It seems like the API now returns the ID and hence this is verifiably a breaking change https://github.com/orgs/community/discussions/9752#discussioncomment-15295321

Versions

I'm running Octokit 4.25.1, but I checked that the code is the same on main as well.

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: TriageThis is being looked at and prioritizedType: BugSomething isn't working as documented

    Type

    No type

    Projects

    Status

    🆕 Triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions