[FIX] web: add fallback to Object.hasOwn in patch function #160758

detrouxdev · 2024-04-05T14:55:08Z

The patch function was changed at commit 1. This introduced a call to Object.hasOwn which is the preferred way to check if an Object has a property as its own. However, after multiple user reports, it seems like a significant amount of user and website visitors still use browsers that do not have Object.hasOwn implemented.

This commit introduces a fallback to Object.prototype.hasOwnProperty for browsers that do not have Object.hasOwn implemented.

opw-3824593

robodoo · 2024-04-05T14:56:16Z

.

rdeodoo

This is correctly fixing the reported issue.

But it seems like after that, there is still a blocking error about OwlError: Cannot make the given value reactive.. which when you close you get another error stack.at is not a function which you can't close ever (don't know if it keeps crashing or the close not closing, it's a bit laggy on browserstack).
I've tested on iphone 12/14.7 and some macOs

Did you face an OS/browser where fixing this was enough to then have a smooth (without error) navigation afterward?

Could you please add Fixes https://github.com/odoo/odoo/issues/142022 in your commit message after the opw tag please?
Sadly, the community already noticed and reported this issue half a year ago 🤦 Sad we don't have a real Github team.

detrouxdev · 2024-04-08T15:24:06Z

@rdeodoo I checked from 15.0 onward because that's the last version of iOS that seems to still be supported by Apple's security patches and the oldest I had available to try on my own computer.

I checked the error you reported and found at least another one. I don't think they're related but I keep getting kicked out of Browser stack when I try to investigate. I'll look more into it tomorrow.

However, it might be good to already go ahead with this one as I can confirm it makes Odoo on iOS versions between 15.0 and 15.3 usable.

rdeodoo · 2024-04-08T15:41:45Z

That's weird, because on your branch on iPhone 13 v15.2 I can indeed see that the import error is gone, but I have this one showing

Note that I don't have any issue in Safari 11 Pro v13.2

detrouxdev · 2024-04-09T07:00:11Z

Indeed, seems like livechat in the frontend introduces the issue because mail has a few calls to .at which are not supported by Safari <15.4

I added a second commit. It should fix that error.

rdeodoo

LGTM, all errors are correctly fixed, tried on iPhone 13 Mini v15.3

Very low effort to support old (but still widely used) iOs devices on the frontend.
Arguably the polyfill could be omitted in the backend assets since for the backend, we ask clients to have an kind of updated browser, which is not the case for frontend visitors. But it can't harm to add it in the backend now that it's there.

@odoo/rd-framework-js Any opinion on this diff? Maybe the hasOwn could also be a global polyfill?

aab-odoo · 2024-04-09T08:17:53Z

@rdeodoo The margin is very tight between telling the customer that those versions aren't supported or introducing those polyfills.

1% of ios safari users are using a version <= 15.3, and 0.54% <= 13.3. This means that this PR will only help 0.46% of ios safari users, as for the 0.54% remaining, it won't work either because of the optional chaining syntax, which their browser doesn't support, and for which we cannot write a polyfill anyway. Moreover, those in [15.0, 15.3] could simply be asked to update, and those below 15.0 are on a version that is no longer supported by apple (according to Arthur).

That being said, those polyfills are harmless, so we agree to introduce them. We would indeed add a global polyfill for hasOwn. That way, polyfills are gathered at a unique place and can be easily clean up when necessary, without polluting the rest of the codebase. They should be added to the frontend assets only.

rdeodoo · 2024-04-09T08:40:30Z

I globally agree, but we are speaking about website visitors, we can't ask them to upgrade, as opposed to Odoo customers.
Since you are ok with that too @aab-odoo , let's go with the hasOwn polyfill @detrouxdev

addons/web/static/src/polyfills/array.js

addons/web/__manifest__.py

The patch function was changed at commit [1]. This introduced a call to `Object.hasOwn` which is the preferred way to check if an Object has a property as its own. However, after multiple user reports, it seems like a significant amount of user and website visitors still use browsers that do not have Object.hasOwn implemented. This commit adds a polyfill to add Obejct.hasOwn in case it is not found. [1]: odoo@04fddc1 Fixes odoo#142022 opw-3824593

Commit [1] refactored the mail code and introduced a few .at called on Array typed objects. This is not supported in lower versions of iOS which some of our users and visitors still use as shown by [2]. This commit introduces a polyfill to support the feature on Safari <=15.3. [1]: odoo@631ae1c [2]: odoo#142022 opw-3824593

rdeodoo

@robodoo r+

God bless those old iPhone users

robodoo · 2024-04-12T17:01:05Z

@detrouxdev @rdeodoo because this PR has multiple commits, I need to know how to merge it:

merge to merge directly, using the PR as merge commit message
rebase-merge to rebase and merge, using the PR as merge commit message
rebase-ff to rebase and fast-forward

rdeodoo · 2024-04-12T17:27:26Z

@robodoo rebase-ff

robodoo · 2024-04-12T17:28:05Z

Merge method set to rebase and fast-forward.

The patch function was changed at commit [1]. This introduced a call to `Object.hasOwn` which is the preferred way to check if an Object has a property as its own. However, after multiple user reports, it seems like a significant amount of user and website visitors still use browsers that do not have Object.hasOwn implemented. This commit adds a polyfill to add Obejct.hasOwn in case it is not found. [1]: 04fddc1 Fixes #142022 opw-3824593 Part-of: #160758

fw-bot · 2024-04-16T05:53:46Z