Hollow wand utilities #223

Soon2BeATaco · 2025-10-09T00:31:20Z

Added hollow wand module for ichor pool (with message sending and waypoint features)
Added a "specific coordinates" optional parameter to PlayerUtils.getPositionString()

…tupid

gemini-code-assist · 2025-10-09T00:31:33Z

Summary of Changes

Hello @Soon2BeATaco, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR introduces a new 'Hollow Wand' module for Ichor Pool management, enabling automatic party chat messages with precise coordinates upon casting and displaying temporary waypoints for incoming Ichor Pool messages. It also updates PlayerUtils to support more granular coordinate reporting.

Highlights

Intent: This pull request introduces a new 'Hollow Wand' module designed to assist with Ichor Pool casting by providing message sending and waypoint features. It also enhances the PlayerUtils.getPositionString() utility to allow for more precise coordinate reporting.
Changes: The primary change is the addition of a new module, HollowWand.kt, which enables users to automatically send their Ichor Pool coordinates to party chat and to visualize incoming Ichor Pool coordinates from party members as temporary waypoints. This module includes settings for enabling/disabling message sending and waypoint display, as well as customizing waypoint color and text size. To support the precise coordinate reporting for the new module, the PlayerUtils.getPositionString() function was modified to accept an optional parameter, allowing it to return coordinates with decimal precision instead of just block coordinates. Additionally, the .gitignore file was updated to ignore .DS_Store files, and the new HollowWand module was registered in ModuleManager.kt.
Reviewer Activity: No specific reviewer activity was provided in the context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

Thank you for this contribution! I've reviewed the changes and have a few suggestions to improve correctness, maintainability, and clarity. My main points are:

In HollowWand.kt, the logic for removing waypoints is not entirely safe and could lead to a crash. I've suggested a more robust implementation.
I've also pointed out a few places where using named arguments would significantly improve code readability, especially for function calls with multiple parameters or boolean flags.
In PlayerUtils.kt, there's a small optimization to be made to avoid unnecessary object creation.

Overall, this is a great addition. Please take a look at my comments. Keep up the good work!

gemini-code-assist · 2025-10-09T00:33:54Z

src/main/kotlin/me/odinmain/features/impl/skyblock/HollowWand.kt

+            val x: Double = it.groups[1]?.value?.toDouble() ?: return@onMessage
+            val y: Double = it.groups[2]?.value?.toDouble() ?: return@onMessage
+            val z: Double = it.groups[3]?.value?.toDouble() ?: return@onMessage
+            poolsToRender.add(IchorPoolCoordinate(x, y, z))
+
+            runIn(400, true) {
+                poolsToRender.removeAt(0)
+            }


Using removeAt(0) is not safe and can lead to an IndexOutOfBoundsException if poolsToRender is cleared (e.g., on world load) before the runIn task executes. It's also fragile if the list is modified elsewhere.

A more robust approach is to remove the specific IchorPoolCoordinate instance that was added. This ensures you're always removing the correct element and avoids crashes on an empty list. I've also used toDoubleOrNull() which is slightly safer.

val x = it.groups[1]?.value?.toDoubleOrNull() ?: return@onMessage val y = it.groups[2]?.value?.toDoubleOrNull() ?: return@onMessage val z = it.groups[3]?.value?.toDoubleOrNull() ?: return@onMessage val newPool = IchorPoolCoordinate(x, y, z) poolsToRender.add(newPool) runIn(400, true) { poolsToRender.remove(newPool) }

Implmenet ^

gemini-code-assist · 2025-10-09T00:33:54Z

src/main/kotlin/me/odinmain/features/impl/skyblock/HollowWand.kt

+
+    private val incomingIchorRegex = Regex("""^Party > (?:\[[\wዞ]+\+*] )?[\w_]+: Ichor Pool x: (-?\d+\.\d{3}), y: (-?\d+), z: (-?\d+\.\d{3})$""")
+    private val outgoingIchorRegex = Regex("""^Casting Spell: Ichor Pool!$""")
+    private val messageSize by NumberSetting("Message Size", 1f, 0.1f, 4f, 0.1f, desc = "Whether or not to display the message size in the box.").withDependency { true }


The dependency { true } is redundant, as settings are visible by default.

Additionally, the description is a bit misleading for a NumberSetting. A clearer description would be better.

Since this setting only affects rendering when showWaypoint is enabled, it should be dependent on it to improve the user experience in the GUI.

Suggested change

private val messageSize by NumberSetting("Message Size", 1f, 0.1f, 4f, 0.1f, desc = "Whether or not to display the message size in the box.").withDependency { true }

private val messageSize by NumberSetting("Message Size", 1f, 0.1f, 4f, 0.1f, desc = "The size of the waypoint text.").withDependency { showWaypoint }

gemini-code-assist · 2025-10-09T00:33:55Z

src/main/kotlin/me/odinmain/features/impl/skyblock/HollowWand.kt

+        if(!showWaypoint) return
+
+        poolsToRender.forEach { pool ->
+            Renderer.drawCylinder(Vec3(pool.x, pool.y, pool.z), 6, 6, 0.05, 80f, 1f, 0f, 90f, 90f, waypointColor, true)


This call to drawCylinder uses many magic numbers, which makes the code hard to understand and maintain. What do 6, 0.05, 80f, etc., represent?

Using named arguments would significantly improve readability by making the purpose of each argument explicit. Consider also defining these values as constants if they are used elsewhere or have special meaning.

Example with named arguments:

Renderer.drawCylinder( pos = Vec3(pool.x, pool.y, pool.z), baseRadius = 6, topRadius = 6, height = 0.05, slices = 80, stacks = 1, rot1 = 0f, rot2 = 90f, rot3 = 90f, color = waypointColor, depth = true )

gemini-code-assist · 2025-10-09T00:33:55Z

src/main/kotlin/me/odinmain/features/impl/skyblock/HollowWand.kt

+
+        poolsToRender.forEach { pool ->
+            Renderer.drawCylinder(Vec3(pool.x, pool.y, pool.z), 6, 6, 0.05, 80f, 1f, 0f, 90f, 90f, waypointColor, true)
+            Renderer.drawStringInWorld("Ichor Pool", Vec3(pool.x, pool.y + 0.5, pool.z), Colors.WHITE, true, 0.03f * messageSize)


Using positional arguments with default values can make the call ambiguous and hard to read. For example, it's not immediately clear what true refers to without looking up the function definition.

Using named arguments would make this call much clearer and more maintainable.

Renderer.drawStringInWorld("Ichor Pool", Vec3(pool.x, pool.y + 0.5, pool.z), color = Colors.WHITE, depth = true, scale = 0.03f * messageSize)

gemini-code-assist · 2025-10-09T00:33:55Z

src/main/kotlin/me/odinmain/utils/skyblock/PlayerUtils.kt


-    fun getPositionString(): String {
+    fun getPositionString(getSpecificCoordinates: Boolean = false): String {
        val blockPos = BlockPos(posX, posY, posZ)


The BlockPos object is created unconditionally, but it's only used in the else branch. To avoid unnecessary object allocation when getSpecificCoordinates is true, you can move the blockPos instantiation inside the else block.

fun getPositionString(getSpecificCoordinates: Boolean = false): String { return if (getSpecificCoordinates) { "x: ${posX.toFixed(3)}, y: ${posY.toFixed(0)}, z: ${posZ.toFixed(3)}" } else { val blockPos = BlockPos(posX, posY, posZ) "x: ${blockPos.x}, y: ${blockPos.y}, z: ${blockPos.z}" } }

odtheking · 2025-10-15T16:02:44Z

gradlew

Why was this file modified?

odtheking · 2025-10-15T16:03:05Z

src/main/kotlin/me/odinmain/features/impl/skyblock/HollowWand.kt

+    data class IchorPoolCoordinate(val x: Double, val y: Double, val z: Double)
+    private val poolsToRender = mutableListOf<IchorPoolCoordinate>()
+
+    private val incomingIchorRegex = Regex("""^Party > (?:\[[\wዞ]+\+*] )?[\w_]+: Ichor Pool x: (-?\d+\.\d{3}), y: (-?\d+), z: (-?\d+\.\d{3})$""")


Use a single " when defining all the regexes

odtheking · 2025-10-15T16:03:40Z

src/main/kotlin/me/odinmain/features/impl/skyblock/HollowWand.kt

+) {
+    private val sendChatMessage by BooleanSetting("Send Message", false, "Sends a message when ichor pool is casted.")
+    private val showWaypoint by BooleanSetting("Show Waypoint", false,"Sends a waypoint when party ichor pool message is detected.")
+    private val waypointColor by ColorSetting("Waypoint Color", Color(166, 21, 3), allowAlpha = false, desc = "Color of the ichor pool waypoint.").withDependency { showWaypoint }


Simply use Colors.MINECRAFT_RED default is allow alpha off so remvoe that

odtheking · 2025-10-15T16:04:09Z

src/main/kotlin/me/odinmain/features/impl/skyblock/HollowWand.kt

+    description = "Messages and waypoints for ichor pool casting."
+) {
+    private val sendChatMessage by BooleanSetting("Send Message", false, "Sends a message when ichor pool is casted.")
+    private val showWaypoint by BooleanSetting("Show Waypoint", false,"Sends a waypoint when party ichor pool message is detected.")


Add a space between the false, and the description

odtheking · 2025-10-15T16:04:23Z

src/main/kotlin/me/odinmain/features/impl/skyblock/HollowWand.kt

+    private val messageSize by NumberSetting("Message Size", 1f, 0.1f, 4f, 0.1f, desc = "Whether or not to display the message size in the box.").withDependency { true }
+
+    init {
+        // Sending Ichor Pool Messages


Pointless comments

odtheking · 2025-10-15T16:04:40Z

src/main/kotlin/me/odinmain/features/impl/skyblock/HollowWand.kt

+    init {
+        // Sending Ichor Pool Messages
+        onMessage(outgoingIchorRegex) {
+            if(!sendChatMessage) return@onMessage


Invert the if statement and inline the send command function call

odtheking · 2025-10-15T16:04:57Z

src/main/kotlin/me/odinmain/features/impl/skyblock/HollowWand.kt

+
+        // Receiving Ichor Pool Messages
+        onMessage(incomingIchorRegex) {
+            val x: Double = it.groups[1]?.value?.toDouble() ?: return@onMessage


No need to explicitly tell its a double

odtheking · 2025-10-15T16:05:22Z

src/main/kotlin/me/odinmain/features/impl/skyblock/HollowWand.kt

+            val x: Double = it.groups[1]?.value?.toDouble() ?: return@onMessage
+            val y: Double = it.groups[2]?.value?.toDouble() ?: return@onMessage
+            val z: Double = it.groups[3]?.value?.toDouble() ?: return@onMessage
+            poolsToRender.add(IchorPoolCoordinate(x, y, z))
+
+            runIn(400, true) {
+                poolsToRender.removeAt(0)
+            }


Implmenet ^

…re consistent across users

Soon2BeATaco added 11 commits October 8, 2025 03:12

Hollow wand utilities

76d8674

Remove .DS_Store files from repo

793dd83

Remove all .DS_Store files

4d3d4e7

Changed base color for ichor pool display

fbce5c4

commit test

ee1958c

attempt to improve accuracy of ichor pool coordinates

1368ee4

Added coordinate specificity

e595605

Removed decimals on y coordinate

98ce87a

Merge branch 'odtheking:main' into main

86c4634

moved hollow wand module over to skyblock from dungeon because I am s…

0a91215

…tupid

Switched hollow wand module's category from dungeon to skyblock

76000a6

gemini-code-assist bot reviewed Oct 9, 2025

View reviewed changes

odtheking requested changes Oct 15, 2025

View reviewed changes

Soon2BeATaco added 4 commits October 16, 2025 18:32

Merge branch 'odtheking:main' into main

da4eeb0

Cleaned up the code base and made it work with another spell

455448e

Removed the crash from modifying a list

0086d7e

Made the raging wind spell waypoint scale according to fps so it's mo…

5ce5251

…re consistent across users

Soon2BeATaco closed this Oct 17, 2025

	private val messageSize by NumberSetting("Message Size", 1f, 0.1f, 4f, 0.1f, desc = "Whether or not to display the message size in the box.").withDependency { true }
	private val messageSize by NumberSetting("Message Size", 1f, 0.1f, 4f, 0.1f, desc = "The size of the waypoint text.").withDependency { showWaypoint }

Uh oh!

Hollow wand utilities #223

Hollow wand utilities #223

Uh oh!

Conversation

Soon2BeATaco commented Oct 9, 2025

Uh oh!

gemini-code-assist bot commented Oct 9, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants