Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: replace custom sheet with drawer component #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 17, 2025
Merged

refactor: replace custom sheet with drawer component #726

merged 16 commits into from
Oct 17, 2025

Conversation

@kmendell
Copy link
Member

@kmendell kmendell commented Oct 17, 2025 •
edited by greptile-apps bot
Loading

Greptile Overview

Updated On: 2025-10-17 04:41:33 UTC

Greptile Summary

This review covers only the changes made since the last review, not the entire PR. The latest changes expand the drawer/sheet refactoring to include significant backend and frontend improvements for sidebar configuration management. New changes add a SidebarHoverExpansion setting that's fully integrated across the entire stack - from database models and DTOs to frontend components. The mobile navigation gets defensive null checking for configuration properties to prevent runtime errors when settings haven't loaded yet. Sidebar navigation is enhanced with improved collapsed state behavior, tooltip functionality for the environment switcher, and better hover expansion logic. The changes maintain backward compatibility while adding user-configurable navigation preferences that sync between frontend and backend.

Important Files Changed

Changed Files
Filename Score Overview
backend/internal/dto/settings_dto.go 5/5 Added SidebarHoverExpansion field to UpdateSettingsDto with proper JSON tagging
backend/internal/models/settings.go 5/5 Added SidebarHoverExpansion as public SettingVariable in Settings struct
backend/internal/services/settings_service.go 5/5 Added default value "true" for SidebarHoverExpansion in getDefaultSettings
frontend/src/lib/types/settings.type.ts 5/5 Added sidebarHoverExpansion boolean field to Settings type definition
frontend/src/routes/settings/navigation/+page.svelte 5/5 Added UI toggle for sidebar hover expansion with error handling for mobile context
frontend/src/lib/components/ui/sidebar/sidebar-provider.svelte 4/5 Added effect to sync sidebar hover expansion with backend settings store
frontend/src/lib/components/sidebar/sidebar-env-switcher.svelte 5/5 Added tooltip showing current environment name on hover over switcher button
frontend/src/lib/components/sidebar/sidebar-itemgroup.svelte 4/5 Implemented flattened navigation hierarchy for collapsed sidebar without hover expansion
frontend/src/lib/components/ui/sidebar/sidebar-menu-button.svelte 4/5 Fixed Tailwind syntax and enhanced collapsed state styling with hover expansion logic
frontend/src/lib/components/mobile-nav/mobile-nav.svelte 4/5 Added defensive null checking for navigationSettings and restructured layout
frontend/src/lib/components/mobile-nav/mobile-nav-sheet.svelte 4/5 Replaced custom sheet with drawer library implementation maintaining existing functionality

Confidence score: 4/5

  • This PR is safe to merge with minimal risk as it adds well-structured configuration management and improves navigation robustness
  • Score reflects solid full-stack implementation patterns and comprehensive error handling, with one point deducted due to complex state synchronization logic and potential race conditions between settings loading and component initialization
  • Pay close attention to frontend/src/lib/components/ui/sidebar/sidebar-provider.svelte for settings synchronization timing and frontend/src/lib/components/mobile-nav/mobile-nav.svelte for null handling completeness

@kmendell kmendell requested a review from a team as a code owner October 17, 2025 02:12
@kmendell kmendell changed the title refactor: replace custom sheet with drawer componen refactor: replace custom sheet with drawer component Oct 17, 2025
greptile-apps[bot]
greptile-apps bot reviewed Oct 17, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

@kmendell
Copy link
Member Author

kmendell commented Oct 17, 2025

@greptileai

greptile-apps[bot]
greptile-apps bot reviewed Oct 17, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. frontend/src/lib/components/ui/sidebar/sidebar-menu-button.svelte, line 15 (link)

    syntax: Inconsistent important syntax - should use !p-0 instead of p-0! to match other declarations

11 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@kmendell kmendell merged commit 718417f into main Oct 17, 2025
12 checks passed
@kmendell kmendell deleted the refactor/drawer-sheet branch October 17, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kmendell @cabaucom376