refactor: パース関数を統合し重複を解消 #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
CLAUDE.mdの高優先度タスク「関数名重複問題の解決」を完了。 ## 変更内容 ### 統合されたパース関数 - `parse-number`: 汎用的な数値パース（失敗時はnilを返却） - `parse-number-or-exit`: エラー時にプロセス終了する数値パース ### 削除された重複関数 - `parse-float` および `safe-parse-float` (util.lisp) - `parse-speed-float` (validate.lisp) ### 修正箇所 - `src/util.lisp`: 新しいパース関数を実装、古い関数を削除 - `src/validate.lisp`: `parse-speed-float`を削除、`parse-number`を使用 - `src/video.lisp`: `safe-parse-float`を`parse-number-or-exit`に置換 - `src/package.lisp`: エクスポートリストを更新 - `t/test-validate.lisp`: テストケースを新しい関数に対応 ## 改善効果 - APIの一貫性向上 - コードの重複排除 - エラーハンドリングの統一 - セキュリティ強化（*read-eval* nil設定） 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
CLAUDE.mdの高優先度タスク「関数名重複問題の解決」を完了しました。
変更内容
統合されたパース関数
parse-number: 汎用的な数値パース（失敗時はnilを返却）parse-number-or-exit: エラー時にプロセス終了する数値パース削除された重複関数
parse-floatおよびsafe-parse-float(util.lisp)parse-speed-float(validate.lisp)修正箇所
src/util.lisp: 新しいパース関数を実装、古い関数を削除src/validate.lisp:parse-speed-floatを削除、parse-numberを使用src/video.lisp:safe-parse-floatをparse-number-or-exitに置換src/package.lisp: エクスポートリストを更新t/test-validate.lisp: テストケースを新しい関数に対応テスト結果
改善効果
*read-eval* nil設定によるコード実行防止🤖 Generated with Claude Code