Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@RomanPodymov
Copy link
Contributor

Hello.
Thank you for Kingfisher.
Continue with Concurrency.

@onevcat
Copy link
Owner

onevcat commented Oct 6, 2022

You can ignore the testing for now. It is a long-existing infra issue.

@RomanPodymov
Copy link
Contributor Author

@onevcat Hello, what should I fix in this pull request?

@onevcat
Copy link
Owner

onevcat commented Oct 11, 2022

@RomanPodymov

I just did not have enough time to take a look at it yet! Sorry for that.

Can you please just call calculateDiskStorageSize inside this async getter? I want to keep no duplication on this as possible, and in the future if we need to apply any change, we can make sure to just do it in one place.

@onevcat onevcat merged commit dffcc08 into onevcat:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants