Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update flix tests and flixkit-go version used #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 18, 2024
Merged

Update flix tests and flixkit-go version used #1339

merged 4 commits into from
Jan 18, 2024

Conversation

@bthaile
Copy link
Contributor

@bthaile bthaile commented Jan 11, 2024 •
edited
Loading

Closes #1335

Description

Simplify flix logic in flow-cli
Reorganize flix.go to be mockable and add unit tests
Use new version of flixkit-go v1.1.0

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@bthaile bthaile marked this pull request as draft January 11, 2024 18:05
@bthaile bthaile marked this pull request as ready for review January 18, 2024 16:45
@bthaile bthaile changed the title Update flix tests Update flix tests and flixkit-go version used Jan 18, 2024
@bthaile bthaile merged commit 7d7686e into master Jan 18, 2024
@bthaile bthaile deleted the update-flix-tests branch January 18, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chasefleming chasefleming chasefleming approved these changes

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee Kay-Zee is a code owner

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@devbugging devbugging Awaiting requested review from devbugging

@nvdtf nvdtf Awaiting requested review from nvdtf nvdtf is a code owner

@bluesign bluesign Awaiting requested review from bluesign

@bjartek bjartek Awaiting requested review from bjartek bjartek is a code owner

@jribbink jribbink Awaiting requested review from jribbink jribbink is a code owner

+1 more reviewer

@ianthpun ianthpun ianthpun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add unit tests for FLIX

4 participants

@bthaile @chasefleming @ianthpun