Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@essell
Copy link

@essell essell commented May 13, 2024

Filters stack traces in both log text and context since they mostly end up here.

@essell
Copy link
Author

essell commented May 13, 2024

Tests successful using composer test as well as in dependent Laravel project.

@arukompas
Copy link
Contributor

hey @essell , thanks for the PR!

Do you think we could have a test for this use case? One to make sure a stack trace within a context string gets filtered, and another to make sure non-stack, multiline context strings don't get affected.

@essell
Copy link
Author

essell commented May 17, 2024

hey @essell , thanks for the PR!

Do you think we could have a test for this use case? One to make sure a stack trace within a context string gets filtered, and another to make sure non-stack, multiline context strings don't get affected.

@arukompas Sure! FYI, the changes I submitted only look through the first level of the context array for stack trace filtering, and doesn't recurse into it deeper. I suspect that it's a rare use case to stick the trace deep into a sub-array, so I opted for simplicity.

@arukompas
Copy link
Contributor

hey @essell , is this PR still relevant, or have you changed your mind about it?

@arukompas arukompas merged commit a576fdc into opcodesio:main Oct 18, 2025
@arukompas
Copy link
Contributor

Thanks @essell , added the tests here - #482

@arukompas
Copy link
Contributor

@essell release tagged - v3.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants