Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Automatically Calculate Friction Values if Missing #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2025
Merged

Automatically Calculate Friction Values if Missing #1120

merged 4 commits into from
Oct 9, 2025
+409 −244

Conversation

@SteelFill
Copy link
Contributor

@SteelFill SteelFill commented Jul 3, 2025 •
edited
Loading

Split from #1072

Discussion thread
Related Trello card

This PR adds the ability for OR to estimate the Davis resistance values of a rail vehicle if an ORTSBearingType has been defined, but some or all of the ORTSDavis values were left undefined. The original Davis formula is used for Grease and Friction bearing types, while the CN resistance formula is used for Roller and Low bearings. (Compare this to the current method, which may set the friction value to 0, or using MSTS friction.)

  • Davis A value is calculated based on the type of bearings, weight of the rail vehicle, and total number of axles (includes support for the special case in the original Davis formula of vehicles weighing less than 5 US tons per axle, and considers extra resistance due to rods on steam locomotives)
  • Davis B value is calculated from the type of bearings, weight of the rail vehicle, and the type of rail vehicle (again, the less than 5 ton per axle case is also considered here)
  • Davis C value is calculated more simply, just using the frontal area and Davis drag constant (both of which have default values if not defined)

Any manually entered friction values are used first, so to tell if automatic calculation is being used due to missing data, enable verbose configuration messages are enabled. Every time something has a resistance component calculated automatically, a message is logged giving the calculated resistance value and the data used to calculate it, which should make it easy to tell when a value was forgotten or if the wagon data is sensible.

ORTS freight animations are supported, with resistance calculated for both the empty and loaded states.

And some general refactoring was done in the way bearings, resistance, and resistance units of measure are handled to make things a little cleaner.

This feature is not intended as a replacement to external friction calculators as it's not possible to account for every case of resistance from within OR, and there are dozens of friction formulas that cannot all be added to OR. If in doubt, do what has always been done and manually enter resistance values, while keeping an eye out for any missing values (which will be indicated in the verbose configuration log).

@SteelFill SteelFill added the enhancement New feature or request label Jul 3, 2025
@SteelFill SteelFill mentioned this pull request Jul 5, 2025
Closed
twpol pushed a commit that referenced this pull request Jul 12, 2025
@openrails-bot
Automatic merge of T1.6-rc4-32-g196d83e86 and 13 pull requests
a66fbd0 
- Pull request #1104 at 6ef735b: Handle simple adhesion within the axle module
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at 7fc8de1: Automatic speed control
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 251a677: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
twpol pushed a commit that referenced this pull request Jul 12, 2025
@openrails-bot
Automatic merge of T1.6-rc4-32-g196d83e86 and 14 pull requests
fdf8da6 
- Pull request #1104 at 6ef735b: Handle simple adhesion within the axle module
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at 7fc8de1: Automatic speed control
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 251a677: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at dc88896: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 12, 2025
@openrails-bot
Automatic merge of T1.6-rc4-32-g196d83e86 and 14 pull requests
15f67d0 
- Pull request #1104 at 6ef735b: Handle simple adhesion within the axle module
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at 7fc8de1: Automatic speed control
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 251a677: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 1527403: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 13, 2025
@openrails-bot
Automatic merge of T1.6-rc4-32-g196d83e86 and 15 pull requests
47b7026 
- Pull request #1104 at 6ef735b: Handle simple adhesion within the axle module
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at 7fc8de1: Automatic speed control
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 251a677: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1136 at 6f1b82f: Fix Curve Resistance Calculation
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 1527403: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 13, 2025
@openrails-bot
Automatic merge of T1.6-rc4-32-g196d83e86 and 15 pull requests
57486b1 
- Pull request #1104 at 9c7cdbf: Handle simple adhesion within the axle module
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at 7fc8de1: Automatic speed control
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 251a677: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1136 at 6f1b82f: Fix Curve Resistance Calculation
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 1527403: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 14, 2025
@openrails-bot
Automatic merge of T1.6-rc4-32-g196d83e86 and 15 pull requests
3ab5894 
- Pull request #1104 at 9c7cdbf: Handle simple adhesion within the axle module
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at 7fc8de1: Automatic speed control
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 251a677: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1136 at 6f1b82f: Fix Curve Resistance Calculation
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 14, 2025
@openrails-bot
Automatic merge of T1.6-rc4-32-g196d83e86 and 14 pull requests
edbcfd3 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at 7fc8de1: Automatic speed control
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1126 at 3bb081e: ShapeHierarchy Attachment for More Wagon Addons
- Pull request #1130 at 251a677: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1136 at 6f1b82f: Fix Curve Resistance Calculation
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
twpol pushed a commit that referenced this pull request Jul 14, 2025
@openrails-bot
Automatic merge of T1.6-rc4-32-g196d83e86 and 15 pull requests
415933b 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at 7fc8de1: Automatic speed control
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1126 at 3bb081e: ShapeHierarchy Attachment for More Wagon Addons
- Pull request #1130 at 251a677: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1136 at 6f1b82f: Fix Curve Resistance Calculation
- Pull request #1137 at c2c9e2a: Apply brakes at startup on minimal reduction
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
twpol pushed a commit that referenced this pull request Jul 15, 2025
@openrails-bot
Automatic merge of T1.6-rc4-32-g196d83e86 and 15 pull requests
2ea670a 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at aa72c13: Automatic speed control
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1126 at 3bb081e: ShapeHierarchy Attachment for More Wagon Addons
- Pull request #1130 at 251a677: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1136 at 6f1b82f: Fix Curve Resistance Calculation
- Pull request #1137 at c2c9e2a: Apply brakes at startup on minimal reduction
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
twpol pushed a commit that referenced this pull request Jul 15, 2025
@openrails-bot
Automatic merge of T1.6-rc4-32-g196d83e86 and 16 pull requests
a96f31b 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at aa72c13: Automatic speed control
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1126 at 3bb081e: ShapeHierarchy Attachment for More Wagon Addons
- Pull request #1130 at 251a677: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1136 at 6f1b82f: Fix Curve Resistance Calculation
- Pull request #1137 at c2c9e2a: Apply brakes at startup on minimal reduction
- Pull request #1138 at 6397400: Calculate wheel speed in simple adhesion
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
twpol pushed a commit that referenced this pull request Jul 15, 2025
@openrails-bot
Automatic merge of T1.6-rc4-32-g196d83e86 and 16 pull requests
3618d4b 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at aa72c13: Automatic speed control
- Pull request #1104 at fd2cabb: Handle simple adhesion within the axle module
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 251a677: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1136 at 6f1b82f: Fix Curve Resistance Calculation
- Pull request #1137 at c2c9e2a: Apply brakes at startup on minimal reduction
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 16, 2025
@openrails-bot
Automatic merge of T1.6-rc4-32-g196d83e86 and 16 pull requests
207d85a 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at aa72c13: Automatic speed control
- Pull request #1104 at fd2cabb: Handle simple adhesion within the axle module
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 736c3f5: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1136 at 6f1b82f: Fix Curve Resistance Calculation
- Pull request #1137 at c2c9e2a: Apply brakes at startup on minimal reduction
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 16, 2025
@openrails-bot
Automatic merge of T1.6-rc4-32-g196d83e86 and 16 pull requests
781eb09 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at aa72c13: Automatic speed control
- Pull request #1104 at fd2cabb: Handle simple adhesion within the axle module
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at fb8a24d: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1136 at 6f1b82f: Fix Curve Resistance Calculation
- Pull request #1137 at c2c9e2a: Apply brakes at startup on minimal reduction
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 18, 2025
@openrails-bot
Automatic merge of T1.6-rc4-34-g041d7ab18 and 16 pull requests
07d4285 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at aa72c13: Automatic speed control
- Pull request #1104 at 0017b1a: Handle simple adhesion within the axle module
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at abe7c8a: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1136 at 6f1b82f: Fix Curve Resistance Calculation
- Pull request #1137 at c2c9e2a: Apply brakes at startup on minimal reduction
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 19, 2025
@openrails-bot
Automatic merge of T1.6-rc4-34-g041d7ab18 and 16 pull requests
d34894f 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at aa72c13: Automatic speed control
- Pull request #1104 at 86d38a2: Handle simple adhesion within the axle module
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at abe7c8a: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1136 at 6f1b82f: Fix Curve Resistance Calculation
- Pull request #1137 at c2c9e2a: Apply brakes at startup on minimal reduction
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 20, 2025
@openrails-bot
Automatic merge of T1.6-rc4-34-g041d7ab18 and 17 pull requests
4af2b15 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at aa72c13: Automatic speed control
- Pull request #1104 at 86d38a2: Handle simple adhesion within the axle module
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at abe7c8a: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1136 at 6f1b82f: Fix Curve Resistance Calculation
- Pull request #1137 at c2c9e2a: Apply brakes at startup on minimal reduction
- Pull request #1139 at b47224d: Fix for bug https://bugs.launchpad.net/or/+bug/2117357. 
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 20, 2025
@openrails-bot
Automatic merge of T1.6-rc4-34-g041d7ab18 and 17 pull requests
87b1df4 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at aa72c13: Automatic speed control
- Pull request #1104 at 86d38a2: Handle simple adhesion within the axle module
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 8ae6bb7: Fix F9 points to an incorrect car ID.
- Pull request #1132 at 934d29e: Fixes For Correct Questionable Braking Parameters
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1136 at 6f1b82f: Fix Curve Resistance Calculation
- Pull request #1137 at c2c9e2a: Apply brakes at startup on minimal reduction
- Pull request #1139 at b47224d: Fix for bug https://bugs.launchpad.net/or/+bug/2117357. 
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 22, 2025
@openrails-bot
Automatic merge of T1.6-rc4-34-g041d7ab18 and 14 pull requests
d323f5b 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at aa72c13: Automatic speed control
- Pull request #1104 at 86d38a2: Handle simple adhesion within the axle module
- Pull request #1110 at 387388e: Fix Activity Runner persists after loading exception
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 8ae6bb7: Fix F9 points to an incorrect car ID.
- Pull request #1133 at 8dc00d5: Minor Fix for Brake Pipe Charging
- Pull request #1139 at b47224d: Fix for bug https://bugs.launchpad.net/or/+bug/2117357. 
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 22, 2025
@openrails-bot
Automatic merge of T1.6-rc5-39-g6dd094783 and 11 pull requests
9feee6e 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1104 at 86d38a2: Handle simple adhesion within the axle module
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 8ae6bb7: Fix F9 points to an incorrect car ID.
- Pull request #1139 at b47224d: Fix for bug https://bugs.launchpad.net/or/+bug/2117357. 
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 24, 2025
@openrails-bot
Automatic merge of T1.6-rc6-37-g6dd094783 and 12 pull requests
cfa5bca 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1104 at 86d38a2: Handle simple adhesion within the axle module
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 8ae6bb7: Fix F9 points to an incorrect car ID.
- Pull request #1139 at b47224d: Fix for bug https://bugs.launchpad.net/or/+bug/2117357. 
- Pull request #1142 at a24747c: Fix light position calculation for deeper hierarchy levels
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 24, 2025
@openrails-bot
Automatic merge of T1.6-rc6-37-g6dd094783 and 12 pull requests
788c1ae 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1104 at 86d38a2: Handle simple adhesion within the axle module
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 8ae6bb7: Fix F9 points to an incorrect car ID.
- Pull request #1139 at 03c6f8f: Fix for bug https://bugs.launchpad.net/or/+bug/2117357. 
- Pull request #1142 at a24747c: Fix light position calculation for deeper hierarchy levels
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 25, 2025
@openrails-bot
Automatic merge of T1.6-rc6-37-g6dd094783 and 13 pull requests
4fad4b5 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1104 at 86d38a2: Handle simple adhesion within the axle module
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 8ae6bb7: Fix F9 points to an incorrect car ID.
- Pull request #1139 at 03c6f8f: Fix for bug https://bugs.launchpad.net/or/+bug/2117357. 
- Pull request #1142 at a24747c: Fix Light Position Calculation for Deeper Hierarchy Levels
- Pull request #1143 at 71e57d2: Status in Work Orders popup set too fast
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 26, 2025
@openrails-bot
Automatic merge of T1.6-rc6-37-g6dd094783 and 14 pull requests
ffdf5e8 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1104 at 86d38a2: Handle simple adhesion within the axle module
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 8ae6bb7: Fix F9 points to an incorrect car ID.
- Pull request #1139 at 03c6f8f: Fix for bug https://bugs.launchpad.net/or/+bug/2117357. 
- Pull request #1142 at a24747c: Fix Light Position Calculation for Deeper Hierarchy Levels
- Pull request #1143 at 71e57d2: Status in Work Orders popup set too fast
- Pull request #1144 at cd790b9: update Spanish translations
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 28, 2025
@openrails-bot
Automatic merge of T1.6-rc6-37-g6dd094783 and 15 pull requests
c651d35 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1104 at 86d38a2: Handle simple adhesion within the axle module
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 8ae6bb7: Fix F9 points to an incorrect car ID.
- Pull request #1139 at 03c6f8f: Fix for bug https://bugs.launchpad.net/or/+bug/2117357. 
- Pull request #1142 at a24747c: Fix Light Position Calculation for Deeper Hierarchy Levels
- Pull request #1143 at 71e57d2: Status in Work Orders popup set too fast
- Pull request #1144 at cd790b9: update Spanish translations
- Pull request #1145 at 875b084: Content Manager: Fix exception when searching; path was added twice to search list.
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Jul 29, 2025
@openrails-bot
Automatic merge of T1.6-rc6-37-g6dd094783 and 16 pull requests
08834b4 
- Pull request #1086 at e10390b: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1104 at 86d38a2: Handle simple adhesion within the axle module
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1130 at 8ae6bb7: Fix F9 points to an incorrect car ID.
- Pull request #1139 at 03c6f8f: Fix for bug https://bugs.launchpad.net/or/+bug/2117357. 
- Pull request #1142 at a24747c: Fix Light Position Calculation for Deeper Hierarchy Levels
- Pull request #1143 at 71e57d2: Status in Work Orders popup set too fast
- Pull request #1144 at cd790b9: update Spanish translations
- Pull request #1145 at 875b084: Content Manager: Fix exception when searching; path was added twice to search list.
- Pull request #1146 at ec44b47: Fix for pantograph events not sent in AI trains
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1081 at 689494b: Brake cuts power unification
- Pull request #1124 at fab5457: Built-in PBL2 brake controller
- Pull request #1128 at 58de4c3: Particle Emitter Overhaul
twpol pushed a commit that referenced this pull request Sep 22, 2025
@openrails-bot
Automatic merge of T1.6-89-ga2a9bbcc8 and 13 pull requests
07b3d5a 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1086 at d8d61eb: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at e813c42: Automatic speed control
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1161 at 6cfe4e2: Fix string trim in .ini files
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1128 at 1d7643d: Particle Emitter Overhaul
- Pull request #1160 at 21e55c8: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Sep 22, 2025
@openrails-bot
Automatic merge of T1.6-89-ga2a9bbcc8 and 13 pull requests
4c9ad64 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1086 at d8d61eb: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at e813c42: Automatic speed control
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1161 at 6cfe4e2: Fix string trim in .ini files
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1128 at 1d7643d: Particle Emitter Overhaul
- Pull request #1160 at 3390e80: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Sep 22, 2025
@openrails-bot
Automatic merge of T1.6-89-ga2a9bbcc8 and 13 pull requests
f69bce2 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1086 at d8d61eb: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1161 at 6cfe4e2: Fix string trim in .ini files
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1128 at 1d7643d: Particle Emitter Overhaul
- Pull request #1160 at 3390e80: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Sep 23, 2025
@openrails-bot
Automatic merge of T1.6-89-ga2a9bbcc8 and 13 pull requests
c8450f0 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1086 at d8d61eb: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1161 at 6cfe4e2: Fix string trim in .ini files
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1128 at 1d7643d: Particle Emitter Overhaul
- Pull request #1160 at c45a926: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Sep 23, 2025
@openrails-bot
Automatic merge of T1.6-89-ga2a9bbcc8 and 14 pull requests
c258b50 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1086 at d8d61eb: Add Settings Exporter tool (copy settings to INI, etc)
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1115 at 270f22f: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1161 at 6cfe4e2: Fix string trim in .ini files
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1128 at 1d7643d: Particle Emitter Overhaul
- Pull request #1160 at c45a926: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Sep 24, 2025
@openrails-bot
Automatic merge of T1.6-104-gfe3b901f2 and 13 pull requests
fbe9f5c 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1115 at cb97e1d: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1161 at 6cfe4e2: Fix string trim in .ini files
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1128 at 1d7643d: Particle Emitter Overhaul
- Pull request #1160 at c45a926: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Sep 25, 2025
@openrails-bot
Automatic merge of T1.6-104-gfe3b901f2 and 13 pull requests
20a4167 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1115 at cb97e1d: Do not activate ETS switch if no suitable cars are attached
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1161 at 6cfe4e2: Fix string trim in .ini files
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1128 at 1d7643d: Particle Emitter Overhaul
- Pull request #1160 at 9dc6b3b: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Sep 29, 2025
@openrails-bot
Automatic merge of T1.6-106-gdcc176472 and 12 pull requests
d7d78dc 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1161 at 6cfe4e2: Fix string trim in .ini files
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1128 at 086d502: Particle Emitter Overhaul
- Pull request #1160 at 9dc6b3b: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Sep 29, 2025
@openrails-bot
Automatic merge of T1.6-106-gdcc176472 and 13 pull requests
88e16bf 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1161 at 6cfe4e2: Fix string trim in .ini files
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1163 at 2f9e292: Fix: Crash when using Camera 8 and F9.
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1128 at 086d502: Particle Emitter Overhaul
- Pull request #1160 at 9dc6b3b: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Sep 29, 2025
@openrails-bot
Automatic merge of T1.6-106-gdcc176472 and 14 pull requests
cb52477 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1161 at 6cfe4e2: Fix string trim in .ini files
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1163 at 2f9e292: Fix: Crash when using Camera 8 and F9.
- Pull request #1164 at 1ad9889: Fix: F9 crashes with a front coupled single steam locomotive by Csantucci.
- Pull request #1082 at 5845a1a: Allow variable water level in glass gauge
- Pull request #1128 at 086d502: Particle Emitter Overhaul
- Pull request #1160 at 9dc6b3b: Route Based TTrack Sounds
@SteelFill SteelFill requested a review from rwf-rr September 30, 2025 02:47
@SteelFill
Copy link
Contributor Author

@rwf-rr Roger, since you've looked at train forces previously, I think you are in a good position to look over this PR. I've been using the feature for a little while without trouble and there's nothing else I want to do with it, no reason for it to sit around even longer.

twpol pushed a commit that referenced this pull request Oct 2, 2025
@openrails-bot
Automatic merge of T1.6-108-g8fb3285d6 and 13 pull requests
e7ea4cf 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1163 at 2f9e292: Fix: Crash when using Camera 8 and F9.
- Pull request #1164 at 1ad9889: Fix: F9 crashes with a front coupled single steam locomotive by Csantucci.
- Pull request #1082 at 50bb779: Allow variable water level in glass gauge
- Pull request #1128 at 086d502: Particle Emitter Overhaul
- Pull request #1160 at 9dc6b3b: Route Based TTrack Sounds
rwf-rr
rwf-rr reviewed Oct 2, 2025
View reviewed changes
twpol pushed a commit that referenced this pull request Oct 3, 2025
@openrails-bot
Automatic merge of T1.6-108-g8fb3285d6 and 13 pull requests
56f7e47 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1163 at 2f9e292: Fix: Crash when using Camera 8 and F9.
- Pull request #1164 at 1ad9889: Fix: F9 crashes with a front coupled single steam locomotive by Csantucci.
- Pull request #1082 at 0cf717c: Allow variable water level in glass gauge
- Pull request #1128 at 086d502: Particle Emitter Overhaul
- Pull request #1160 at 9dc6b3b: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Oct 3, 2025
@openrails-bot
Automatic merge of T1.6-108-g8fb3285d6 and 13 pull requests
7b9f96a 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1163 at 2f9e292: Fix: Crash when using Camera 8 and F9.
- Pull request #1164 at 1ad9889: Fix: F9 crashes with a front coupled single steam locomotive by Csantucci.
- Pull request #1082 at 5d1572f: Allow variable water level in glass gauge
- Pull request #1128 at 086d502: Particle Emitter Overhaul
- Pull request #1160 at 9dc6b3b: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Oct 4, 2025
@openrails-bot
Automatic merge of T1.6-108-g8fb3285d6 and 13 pull requests
a12254e 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1163 at 2f9e292: Fix: Crash when using Camera 8 and F9.
- Pull request #1164 at 1ad9889: Fix: F9 crashes with a front coupled single steam locomotive by Csantucci.
- Pull request #1082 at d3722cd: Allow variable water level in glass gauge
- Pull request #1128 at 086d502: Particle Emitter Overhaul
- Pull request #1160 at 9dc6b3b: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Oct 4, 2025
@openrails-bot
Automatic merge of T1.6-108-g8fb3285d6 and 13 pull requests
ab93d15 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1163 at 2f9e292: Fix: Crash when using Camera 8 and F9.
- Pull request #1164 at 1ad9889: Fix: F9 crashes with a front coupled single steam locomotive by Csantucci.
- Pull request #1082 at 625c917: Allow variable water level in glass gauge
- Pull request #1128 at 086d502: Particle Emitter Overhaul
- Pull request #1160 at 9dc6b3b: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Oct 4, 2025
@openrails-bot
Automatic merge of T1.6-108-g8fb3285d6 and 13 pull requests
27a89c8 
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1120 at ba3c47f: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1163 at 2f9e292: Fix: Crash when using Camera 8 and F9.
- Pull request #1164 at 1ad9889: Fix: F9 crashes with a front coupled single steam locomotive by Csantucci.
- Pull request #1082 at 56bb992: Allow variable water level in glass gauge
- Pull request #1128 at 086d502: Particle Emitter Overhaul
- Pull request #1160 at 9dc6b3b: Route Based TTrack Sounds
rwf-rr
rwf-rr reviewed Oct 4, 2025
View reviewed changes
Copy link
Contributor

@rwf-rr rwf-rr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look fine to me, though I do not always fully understand the reason behind the changes.
Since I am not yet familiar with the details in the friction calculations, I would prefer if a second reviewer provided feedback before approving the PR.

twpol pushed a commit that referenced this pull request Oct 5, 2025
@openrails-bot
Automatic merge of T1.6-108-g8fb3285d6 and 13 pull requests
fd59430 
- Pull request #1082 at 56bb992: Allow variable water level in glass gauge
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1120 at 47e9955: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1163 at 2f9e292: Fix: Crash when using Camera 8 and F9.
- Pull request #1164 at 1ad9889: Fix: F9 crashes with a front coupled single steam locomotive by Csantucci.
- Pull request #1128 at 086d502: Particle Emitter Overhaul
- Pull request #1160 at 9dc6b3b: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Oct 5, 2025
@openrails-bot
Automatic merge of T1.6-108-g8fb3285d6 and 13 pull requests
d0246f4 
- Pull request #1082 at 2d20539: Allow variable water level in glass gauge
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1120 at 47e9955: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1163 at 2f9e292: Fix: Crash when using Camera 8 and F9.
- Pull request #1164 at 1ad9889: Fix: F9 crashes with a front coupled single steam locomotive by Csantucci.
- Pull request #1128 at 086d502: Particle Emitter Overhaul
- Pull request #1160 at 9dc6b3b: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Oct 5, 2025
@openrails-bot
Automatic merge of T1.6-108-g8fb3285d6 and 13 pull requests
e37370f 
- Pull request #1082 at 8538170: Allow variable water level in glass gauge
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1120 at 47e9955: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1128 at d116396: Particle Emitter Overhaul
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1162 at 2516cce: specifies precedence of DDS over ACE
- Pull request #1163 at 2f9e292: Fix: Crash when using Camera 8 and F9.
- Pull request #1164 at 1ad9889: Fix: F9 crashes with a front coupled single steam locomotive by Csantucci.
- Pull request #1160 at 9dc6b3b: Route Based TTrack Sounds
twpol pushed a commit that referenced this pull request Oct 7, 2025
@openrails-bot
Automatic merge of T1.6-110-g9e88e3ae1 and 13 pull requests
70a14ed 
- Pull request #1082 at 8538170: Allow variable water level in glass gauge
- Pull request #1156 at f46d5f2: Fix incorrectly disabled options in train operations window
- Pull request #1091 at 492795a: Automatic speed control
- Pull request #1120 at 47e9955: Automatically Calculate Friction Values if Missing
- Pull request #1121 at 91d2d26: Manually Override Articulation
- Pull request #1124 at e241a0d: Built-in PBL2 brake controller
- Pull request #1128 at d116396: Particle Emitter Overhaul
- Pull request #1157 at 39cd994: Dynamic brake authorization by TCS
- Pull request #1159 at 48c9a63: Skip OR warnings about TSRE-specific token Ruler
- Pull request #1163 at 2f9e292: Fix: Crash when using Camera 8 and F9.
- Pull request #1164 at 1ad9889: Fix: F9 crashes with a front coupled single steam locomotive by Csantucci.
- Pull request #1165 at 168c27c: docs: Add code guidelines for logging
- Pull request #1160 at 9dc6b3b: Route Based TTrack Sounds
@rwf-rr
Copy link
Contributor

rwf-rr commented Oct 8, 2025

I have started some testing, and so far everything looks good.
TrainSimulations has the same freight car with Friction (Mullen Pass) and Davis (Seligman) values. Using the auto-determine values for the Mullen Pass car results in very similar behaviour as the Seligman version of the car.

@rwf-rr
Copy link
Contributor

rwf-rr commented Oct 8, 2025 •
edited
Loading

I completed my testing, and everything looks good.
A couple of observations:

  • The calculated Davis-B value is about twice the value that TrainSimulations used (in Seligman freight car). Calculated A and C match what TrainSimulations used.
  • Empty cars have a bit higher resistance (calculated vs TrainSimulations). Loaded cars have very similar resistance as TrainSimulations.

These are just observations, I have no way to judge if the calculated values are more realistic, or the TrainSimulation configured ones are. Both seem reasonable.

@SteelFill
Copy link
Contributor Author

I completed my testing, and everything looks good. A couple of observations:

  • The calculated Davis-B value is about twice the value that TrainSimulations used (in Seligman freight car). Calculated A and C match what TrainSimulations used.
  • Empty cars have a bit higher resistance (calculated vs TrainSimulations). Loaded cars have very similar resistance as TrainSimulations.

These are just observations, I have no way to judge if the calculated values are more realistic, or the TrainSimulation configured ones are. Both seem reasonable.

Yeah that's intended. I figure TrainSimulations calculated their resistance values with the FCalc program, but the formulas used by FCalc are not the same as what Davis actually used.

Like, in the case of the B value for roller bearings specifically, FCalc uses 0.015 x weight to get the B value, but the CN test report says this should be 0.03 x weight, so literally twice as much. Similar discrepancies are true for some of the other calculations. I'm not sure why FCalc uses the values it does, but I'd rather follow the original research than a secondary source.

In any case, thanks for double checking things, it helps to have another look to be sure things are reasonable, as reasonable is the objective.

@SteelFill SteelFill merged commit 0d2de70 into openrails:master Oct 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwf-rr rwf-rr rwf-rr approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SteelFill @rwf-rr