Improved pull request "Files Changed" experience feedback #163932
Replies: 2440 comments 901 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
|
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
|
A PR with a faulty CODEOWNER, doesn't show that the file is wrong anymore in the PR review diff |
Beta Was this translation helpful? Give feedback.
-
|
What the ACTUAL HOLY *****? One file at a time in the Files Changed diff tab? NO NO NO NO NO NO NO. |
Beta Was this translation helpful? Give feedback.
-
|
Nearly impossible to see file modified color icon vs new file icon in the file tree. Extremely poor accessibility there. Make file changes orange again, please. |
Beta Was this translation helpful? Give feedback.
-
|
the horizontal/vertical line spaces just take up screen real estate without adding any benefit. The distinctive sections already have a clear divider. |
Beta Was this translation helpful? Give feedback.
-
|
Pressing |
Beta Was this translation helpful? Give feedback.
-
|
Bug: I cannot see the diff with the new experience on this PR, and get the following error message:
Here is a gif showing that enabling the new experience breaks the diff view: My guess would be that this has something to do with the PR coming from a ref in another repo. |
Beta Was this translation helpful? Give feedback.
-
|
I'm working on a large PR and have more than 40 comments. I didn't realize the new UI only shows 40 comments and that's not configurable. When I got back to the PR today I saw a lot of my most recent comments "missing" and thought they were lost, as there was no indicator in the file(s) I was looking at that there are comments, but are hidden. Switching back to classic view brought those comments back so I could see/edit them, but then the order of the files changed. This is very frustrating. What am I missing? What is the intended workflow here? |
Beta Was this translation helpful? Give feedback.
-
|
I cannot easily review commit per commit with (N)ext and (P)revious shortcuts anymore. |
Beta Was this translation helpful? Give feedback.
-
|
Lowercase (j) and (k) work to go forward and backward through files but the uppercase variants (J) and (K) do not work (e.g. caps lock is on). The tooltips show capital letters. |
Beta Was this translation helpful? Give feedback.
-
|
The edit button is missing, did that get replaced? |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
The number of viewed files is greater than the number of files in the PR... |
Beta Was this translation helpful? Give feedback.
-
|
I like the new file by file view for reviewing, however not showing all comments when viewing an individual file, or all the files in the sidebar isn't particularly helpful and a significant issue for code review.
|
Beta Was this translation helpful? Give feedback.
-
|
I was not able to add a mutli-line suggestion |
Beta Was this translation helpful? Give feedback.
-
|
this preview version is unusable when opening the last change on a given PR
the worst is that I cannot switch back anymore to the classic view, now it always shows the new macOS Tahoe 26.1, Firefox 146.0 (aarch64 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Important
We're actively working to improve performance. As part of this, the single file mode, which was a temporary solution while we addressed scale and performance issues, will transition to an "opt-in" feature rather than one that is forced on because of the size of the pull request. We're also working to increase the limits on comments, etc.
We know appreciate your patience! ❤️
About the new experience
This refresh focuses on performance, accessibility, and clarity so reviews stay responsive—even on the largest pull requests.
Tip
To opt into the public preview, click the ✨Try the new experience in the upper-right of the "Files changed" page. You can easily switch back by clicking Switch back.
✨ What's new
See what's been fixed and improved since the launch of the public preview:
User experience
Accessibility
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions