You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support to Facebook OIDC provider for verified Graph API calls.
Facebook allow Apps to enable a security flag that requires proof on all API calls as explained in their documentation
Related issue(s)
The current Facebook provider code does not support this flag and the claims retrieval will silently fail with no claims available. When we check the logs returned by the API call made to the Graph API it returns an error of this type
{
"error": {
"message": "API calls from the server require an appsecret_proof argument",
"type": "GraphMethodException",
"code": 100,
"fbtrace_id": "AJWp8p6GrKrNml7iA4eIadU"
}
}
This PR add code to compute the appsecret_proof and use it on the Graph API call made to retrieve claims.
I confirm that this pull request does not address a security vulnerability.
If this pull request addresses a security. vulnerability,
I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
I have added tests that prove my fix is effective or that my feature works.
Merging #2547 (52bffee) into master (2aeb0a2) will increase coverage by 0.28%.
The diff coverage is 100.00%.
❗ Current head 52bffee differs from pull request most recent head 5ba72a4. Consider uploading reports for the commit 5ba72a4 to get more accurate results
Hello @sayoun
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community. Please drop me an email and I will forward you the form to claim your Ory swag!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support to Facebook OIDC provider for verified Graph API calls.
Facebook allow Apps to enable a security flag that requires proof on all API calls as explained in their documentation
Related issue(s)
The current Facebook provider code does not support this flag and the claims retrieval will silently fail with no claims available. When we check the logs returned by the API call made to the Graph API it returns an error of this type
{ "error": { "message": "API calls from the server require an appsecret_proof argument", "type": "GraphMethodException", "code": 100, "fbtrace_id": "AJWp8p6GrKrNml7iA4eIadU" } }This PR add code to compute the
appsecret_proofand use it on the Graph API call made to retrieve claims.Checklist
If this pull request addresses a security. vulnerability,
I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.