Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@aeneasr
Copy link
Member

@aeneasr aeneasr commented May 19, 2022

BREAKING CHANGE: Please be aware that the SDK method signatures for submitSelfServiceRecoveryFlow, submitSelfServiceRegistrationFlow, submitSelfServiceLoginFlow, submitSelfServiceSettingsFlow, submitSelfServiceVerificationFlow might have changed in your SDK.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

BREAKING CHANGE: Please be aware that the SDK method signatures for `submitSelfServiceRecoveryFlow`, `submitSelfServiceRegistrationFlow`, `submitSelfServiceLoginFlow`, `submitSelfServiceSettingsFlow`, `submitSelfServiceVerificationFlow` might have changed in your SDK.
@aeneasr aeneasr requested a review from zepatrik as a code owner May 19, 2022 16:00
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #2479 (7185044) into master (93bf1e2) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2479      +/-   ##
==========================================
- Coverage   76.56%   76.52%   -0.04%     
==========================================
  Files         316      316              
  Lines       17603    17603              
==========================================
- Hits        13477    13470       -7     
- Misses       3192     3198       +6     
- Partials      934      935       +1     
Impacted Files Coverage Δ
selfservice/flow/login/handler.go 80.83% <ø> (ø)
selfservice/flow/recovery/handler.go 62.50% <ø> (ø)
selfservice/flow/registration/handler.go 78.57% <ø> (ø)
selfservice/flow/settings/handler.go 68.91% <ø> (ø)
selfservice/flow/verification/handler.go 65.09% <ø> (ø)
courier/courier_dispatcher.go 56.86% <0.00%> (-9.81%) ⬇️
persistence/sql/persister_courier.go 86.76% <0.00%> (-2.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93bf1e2...7185044. Read the comment docs.

Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@aeneasr aeneasr merged commit c9ae117 into master May 19, 2022
@aeneasr aeneasr deleted the fix-kratos-sdk-order branch May 19, 2022 16:41
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
BREAKING CHANGE: Please be aware that the SDK method signatures for `submitSelfServiceRecoveryFlow`, `submitSelfServiceRegistrationFlow`, `submitSelfServiceLoginFlow`, `submitSelfServiceSettingsFlow`, `submitSelfServiceVerificationFlow` might have changed in your SDK.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants