Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@laeubi
Copy link
Contributor

@laeubi laeubi commented Apr 27, 2024

Fix #718

@stbischof
Copy link
Contributor

@laeubi please update also the spec.

Copy link
Contributor

@chrisrueger chrisrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments.

@laeubi
Copy link
Contributor Author

laeubi commented May 9, 2024

I tried to address the comments and adjusted the spec here is the generated specification: osgi.cmpn-8.1.0.pdf

Copy link
Contributor

@chrisrueger chrisrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I like the clarifications in the testcase.
  • I suggested a small typo correction

I just comment (instead of approve) because I don't feel I am qualified enough to judge this, since I was late in the game. But it sounds reasonable and makes sense to me.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be closed if no further activity occurs. If you intend to work on this pull request, please reopen the PR. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 11, 2025
@laeubi
Copy link
Contributor Author

laeubi commented May 11, 2025

Still an issue ...

@stbischof
Copy link
Contributor

lets bring this up next spec call.
will you also do the impementation ?

@laeubi
Copy link
Contributor Author

laeubi commented May 11, 2025

This is how it is implemented in Equinox ATM see:

@github-actions github-actions bot removed the stale label May 12, 2025
@laeubi
Copy link
Contributor Author

laeubi commented Sep 4, 2025

@stbischof @tjwatson I think we have already agreed on this in the spec call can we proceed here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tck][cm] CMCoordinationTestCase#testCoordinatedConfigurationOnBeforeRegisteredManagedService seems to contain to strict assertions

3 participants