Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JamieMagee
Copy link
Contributor

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

ListIssues and GetCreatedAt throw an unsupported error

What is the new behavior (if this is a feature change)?**

ListIssues and GetCreatedAt have implementations

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Next step of #4177

Special notes for your reviewer

Azure DevOps doesn't have an official API to retrieve user permissions for a project or a repository. As a stopgap solution, I've defaulted all issue and comment authors to RepoAssociationMember. This is probably a good minimum bar.

The audit log is the best way to retrieve the repository creation date, but this may not be enabled. So I am using the first repository commit as a fallback value.

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

implement `ListIssues` and `GetCreatedAt` for Azure DevOps

@JamieMagee JamieMagee requested a review from a team as a code owner November 23, 2024 06:34
@JamieMagee JamieMagee requested review from raghavkaul and spencerschrock and removed request for a team November 23, 2024 06:34
@JamieMagee
Copy link
Contributor Author

With these changes the Maintained check now completes

Details
$ env SCORECARD_EXPERIMENTAL=1 go run . --repo dev.azure.com/jamiemagee/jamiemagee/_git/jamiemagee --checks Maintained
Starting [Maintained]
Finished [Maintained]

RESULTS
-------
Aggregate score: 5.0 / 10

Check scores:
|--------|------------|--------------------------------|-----------------------------------------------------------------------|
| SCORE  |    NAME    |             REASON             |                       DOCUMENTATION/REMEDIATION                       |
|--------|------------|--------------------------------|-----------------------------------------------------------------------|
| 5 / 10 | Maintained | 5 commit(s) and 1 issue        | https://github.com/ossf/scorecard/blob/main/docs/checks.md#maintained |
|        |            | activity found in the last 90  |                                                                       |
|        |            | days -- score normalized to 5  |                                                                       |
|--------|------------|--------------------------------|-----------------------------------------------------------------------|

@codecov
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 50.25907% with 96 lines in your changes missing coverage. Please review.

Project coverage is 68.57%. Comparing base (353ed60) to head (5487fda).
Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4419      +/-   ##
==========================================
+ Coverage   66.80%   68.57%   +1.77%     
==========================================
  Files         230      238       +8     
  Lines       16602    17768    +1166     
==========================================
+ Hits        11091    12185    +1094     
+ Misses       4808     4785      -23     
- Partials      703      798      +95     

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JamieMagee JamieMagee force-pushed the azure-devops-audit-issues branch from adac8b0 to 5487fda Compare December 2, 2024 23:32
@spencerschrock spencerschrock merged commit 57850ee into ossf:main Dec 3, 2024
37 of 38 checks passed
@JamieMagee JamieMagee deleted the azure-devops-audit-issues branch December 3, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants