Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@RocFang
Copy link
Contributor

@RocFang RocFang commented Jan 4, 2018

Hi, @winlinvip

there are two points may need to be update:

  1. In function of start, since srs is already running and failed_msg is used, maybe it's not proper to return 0.
  2. this check will always success after ret=$?

thanks.

@winlinvip winlinvip changed the base branch from master to 2.0release January 4, 2018 05:44
@winlinvip
Copy link
Member

👍 I will merge to 2.0release/3.0release/develop.
I will merge to master when next version of 2.0release is released.

@winlinvip winlinvip merged commit d22d7af into ossrs:2.0release Jan 4, 2018
winlinvip added a commit that referenced this pull request Jan 4, 2018
@RocFang RocFang deleted the patch-1 branch January 4, 2018 06:10
@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EnglishNative This issue is conveyed exclusively in English.

Development

Successfully merging this pull request may close these issues.

2 participants