Use MultiPatternDetector for all client logs and crash reports #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all occurrences of
SinglePatternDetectorwithMultiPatternDetectorto get rid of one long, complex and inefficient regular expression and replace it with two regular expressions that are easier to read, understand and (hopefully) faster to parse.This PR updates aternos/codex to 2.2.0 to use the new
MultiPatternDetectorintroduced in aternosorg/codex#21.This PR also fixes #87 as we no longer use expressions like
*(\n.*)*, so the regular expression parser should no longer encounter errors likeJIT stack limit exhausted.This PR also contains these changes:
Is Modded: Definitely; Client brand changed to 'arclight'/---- Minecraft Crash Report ----(\n.*)*\n\tFML:/m/^\tNeoForge: net\.neoforged:/minstead of\tNeoForge:/m