Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
added 10 commits
April 8, 2025 11:27
printhellohetal
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
pytestwithnbmakein our CI pipeline to more reliably test the notebooks and allow for more granular notebook cell testing in the future. GitHub actions has also been improved to show JUnit tests directly in the GitHub Actions UI + upload an HTML report as artifacts to the workflow.Things to note:
ruffwas updated as per the extra dependencies added topyproject.toml. As a result, files have been formatted according to the updated standards for the newest version.makefilemakes this more seamless), so we should still leave the ruff formatting check in the CI pipeline.