Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding PyTest to CI pipelines#991

Merged
andrewyang94 merged 17 commits intomainfrom
ac-15-adding-pytest
May 9, 2025
Merged

Adding PyTest to CI pipelines#991
andrewyang94 merged 17 commits intomainfrom
ac-15-adding-pytest

Conversation

@andrewyang94
Copy link
Contributor

@andrewyang94 andrewyang94 commented Apr 7, 2025

This PR implements pytest with nbmake in our CI pipeline to more reliably test the notebooks and allow for more granular notebook cell testing in the future. GitHub actions has also been improved to show JUnit tests directly in the GitHub Actions UI + upload an HTML report as artifacts to the workflow.

Things to note:

  • ruff was updated as per the extra dependencies added to pyproject.toml. As a result, files have been formatted according to the updated standards for the newest version.
  • Added a pre-commit hook to ensure that files are formatted using ruff before pushing to the repo, rather than later where the CI pipeline performs the check after the commit has already made it to the repo, ultimately wasting time, compute resources, and mucking up commit history to fail downstream rather than upstream. There is no way to force a user to install a pre-commit hook (although adding to the makefile makes this more seamless), so we should still leave the ruff formatting check in the CI pipeline.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@andrewyang94 andrewyang94 self-assigned this Apr 8, 2025
@andrewyang94 andrewyang94 merged commit 3c2f366 into main May 9, 2025
4 checks passed
@andrewyang94 andrewyang94 deleted the ac-15-adding-pytest branch May 9, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants