Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rails/rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: aub/rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 5 files changed
  • 1 contributor

Commits on Dec 28, 2009

  1. There is currently a bug in ActiveRecord where you will get an infinite 

    loop if you try to use a has_many :through association with a nonstandard
primary key. This happens because the association calls owner_quoted_id in
construct_quoted_owner_attributes, and owner_quoted_id calls
quote_value. The problem is that quote_value is not defined on the
association itself and needs to be called through method_missing. The
method_missing implementation in association_collection tries to send
the method through to the reflection's class, but only after calling
construct_scope, and that method ends up calling owner_quoted_id again,
creating an infinite loop. This patch implements the quote_value method
on AssociationCollection to send the call directly to the reflection's
class without going through method_missing.
(cherry picked from commit 3fd3086)

Conflicts:

	activerecord/test/cases/associations/has_many_through_associations_test.rb
    Aubrey Holland committed Dec 28, 2009
    Configuration menu
    Copy the full SHA
    b1b6740 View commit details
    Browse the repository at this point in the history
Loading