fix invalid metric due to hyphen in protocol name #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uffered gauge on prometheus scrapping
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.12.3 #911 +/- ##
===================================================
- Coverage 71.93% 71.35% -0.58%
===================================================
Files 27 29 +2
Lines 3278 3393 +115
===================================================
+ Hits 2358 2421 +63
- Misses 725 757 +32
- Partials 195 215 +20 ☔ View full report in Codecov by Sentry. |
lorenzo-dev1
approved these changes
Dec 21, 2023
yazzaoui
reviewed
Dec 21, 2023
| return nil, fmt.Errorf("dial failed: %v", err) | ||
| } | ||
| conn.caps = append(conn.caps, p2p.Cap{Name: "aut-snap", Version: 1}) | ||
| conn.caps = append(conn.caps, p2p.Cap{Name: "aut_snap", Version: 1}) |
There was a problem hiding this comment.
This will cause devp2p snap protocol match to fail with the old 0.12.2 version - but I guess it's fine.
404a531 to
b1608de
Compare
|
Can you disable the buffered gauge tests so we can have the e2e tests running on CI |
Thanks for taking care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix invalid metric due to hyphen in protocol name
Avoid warnings on buffered gauge on prometheus scrapping.