Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@weklund
Copy link
Contributor

@weklund weklund commented Oct 31, 2025

Fixes #933

@weklund weklund changed the title !chore: Upgrade lambda runtime version from using 18 (EoL) to 20 chore!: Upgrade lambda runtime version from using 18 (EoL) to 20 Oct 31, 2025
@weklund
Copy link
Contributor Author

weklund commented Oct 31, 2025

Happy to make changes if there's something I'm missing in definition of done. Looked at https://aws.github.io/aws-pdk/contributing/index.html

@cogwirrel
Copy link
Member

Happy to make changes if there's something I'm missing in definition of done. Looked at https://aws.github.io/aws-pdk/contributing/index.html

Thanks so much for contributing @weklund ! You'll need to update the snapshots for the tests to pass - are you able to run pnpm build locally? That should run the tests and update the snapshots. If you run into trouble I can do this and push to your PR :)

@cogwirrel
Copy link
Member

Ooh also please can you mark your PR as a fix as chore will skip publishing to NPM https://github.com/aws/aws-pdk/blob/mainline/.github/workflows/release.yml#L47

@weklund
Copy link
Contributor Author

weklund commented Oct 31, 2025

Can do! @cogwirrel

@cogwirrel cogwirrel merged commit ae9a4ef into aws:mainline Oct 31, 2025
3 checks passed
@weklund
Copy link
Contributor Author

weklund commented Nov 3, 2025

Looks like the maven publish failed on mainline? Should I have done anything differently @cogwirrel ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node JS runtime for PDK created Lambda approaching EoL

2 participants