Fix "Nines" bug and add tests #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes 999 bug
n < 1000 was skipping While block and showing many decimals, if input had many decimals.
Open
|
@azaitsev, could you please look into this PR? Let me know if any additional tests are desirable. If you merge this PR, could you deploy a new version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in this PR is build on top of @weefatboi's work (#2).
tests\test_millify.pynow contains unit tests that test the fix by @weefatboi, and the existing code. Based on the tests, three changes are made to__init__.py:prettify()with a custom separator, the custom separator only appeared as last thousand separator. This is fixed by passing separator on the recursive call ofprettify().After these changes, all tests were passed.