SMQ-3137 - Proxy CoAP using mgate #2222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@felixgateru Please resolve conflicts. |
01c3593 to
bedc5b3
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
bedc5b3 to
d7da4fa
Compare
e84d707 to
c9dcaaa
Compare
rodneyosodo
requested changes
Sep 23, 2025
docker/.env
Outdated
| SMQ_COAP_ADAPTER_PORT=5683 | ||
| SMQ_COAP_ADAPTER_SERVER_CERT= | ||
| SMQ_COAP_ADAPTER_SERVER_KEY= | ||
| SMQ_COAP_ADAPTER_SERVER_CA_FILE= |
Contributor
There was a problem hiding this comment.
- DTLS certs are not mapped inside the container
- DTLS certs are not correctly inputed
SMQ_COAP_ADAPTER_SERVER_CERT_FILE=""
- On
docker/ssl/Makefile, lets add this so that we can generate CoAP server certs
COAP_GRPC_SERVER_CONF_FILE_NAME=coap-server.conf
COAP_GRPC_SERVER_CN=coap
COAP_GRPC_SERVER_CRT_FILE_NAME=coap-server
coap_grpc_certs:
$(call gen_grpc_cert,$(COAP_GRPC_SERVER_CRT_FILE_NAME),$(COAP_GRPC_SERVER_CN))
- We should consider an env variable that enables
COAP_DTLSsame asGRPC_MTLS
c9dcaaa to
1783a8d
Compare
rodneyosodo
requested changes
Sep 24, 2025
Contributor
rodneyosodo
left a comment
There was a problem hiding this comment.
We should also consider updating the docs repo for this new feature
26f3e6b to
737dc19
Compare
737dc19 to
0a2dce6
Compare
arvindh123
requested changes
Sep 30, 2025
| } | ||
|
|
||
| clientID := authnRes.GetId() | ||
| authzRes, err := svc.channels.Authorize(ctx, &grpcChannelsV1.AuthzReq{ |
Contributor
There was a problem hiding this comment.
Is it possible to remove the channel authorization while unsubscribing ?
Lines 116 to 128 in 69b849c
5a2c870 to
549f259
Compare
d3865c3 to
2fc1dc7
Compare
rodneyosodo
previously approved these changes
Oct 16, 2025
Contributor
|
@dborovcanin, please review and let's merge |
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
2fc1dc7 to
031f3fb
Compare
dborovcanin
requested changes
Oct 24, 2025
coap/handler.go
Outdated
Comment on lines
29
to
32
| LogInfoSubscribed = "subscribed with client_id %s to topics %s" | ||
| LogInfoConnected = "connected with client_id %s" | ||
| LogInfoDisconnected = "disconnected client_id %s and username %s" | ||
| LogInfoPublished = "published with client_id %s to the topic %s" |
Collaborator
There was a problem hiding this comment.
Don't export unless necessary. Also, add fmt suffix to indicate this is format. Like subscribedInfoFmt, connectedInfoFmt...
docker/ssl/.gitignore
Outdated
| *conf | ||
| client.crt | ||
| client.key | ||
| *coap-server* |
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
031f3fb to
fcab001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it updates the coap adapter to use mgate to procy plain udp traffic and dtls traffic.
What does this do?
This pr updates the coap adapter to use mgate for proxtying
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No
Did you document any new/modified feature?
No
Notes