Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@johnb432
Copy link
Contributor

When merged this pull request will:

  • No longer require seats to inherit from Thing. This allows mods (including other components in ACE) to define classes inheriting from e.g. Static to be seats.
  • Add a safeguard to FUNC(addSitActions), so if it's called by mod and mission makers, it's executed after settings are initialised.
  • Store the people sitting on the seats, so that multiple people can sit at once. Fixes ACE Sitting only allows 1 sitter on multi-seatable objects #10486.
  • Pass new ownership onto other people sitting, if existent, instead of keeping it until everyone has left the bench.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Jan 12, 2025
@LinkIsGrim LinkIsGrim added this to the 3.18.3 milestone Jan 13, 2025
@LinkIsGrim LinkIsGrim modified the milestones: 3.18.3, 3.18.2 Jan 13, 2025
@LinkIsGrim LinkIsGrim merged commit 064e1eb into master Jan 13, 2025
3 checks passed
@LinkIsGrim LinkIsGrim deleted the sitting-improvements branch January 13, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ACE Sitting only allows 1 sitter on multi-seatable objects

4 participants