-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Description
This is only a minor suggestion, but I found this confusing:
Lines 219 to 225 in 239c48f
| const errDisabledTestEnv = "PERF_TEST_ERR_DISABLED" | |
| func init() { | |
| // In child process of testErrDisabledProcessExist. | |
| if os.Getenv(errDisabledTestEnv) != "1" { | |
| return | |
| } |
-
Variables/consts beginning with the name
errare usually errors. -
It refers to testErrDisabledProcessExist which doesn't exist.
-
It's unclear from the comment which side of the branch is "in" something. Is it in the returning side, or the non-returning side? This might be a rare case where "early return" is a minor hinderance and perhaps it would be better to phrase it positively, and move the body of code out, to make it clear when the special condition matches:
func init() { if specialCondition { doSpecialCondition() } }
Metadata
Metadata
Assignees
Labels
No labels