Implement Chen+24 particle spray model #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks @ybillchen -- this is looking great! I fixed some issues related to numpy 2.0, so to get the tests to pass you will need to rebase this PR. Let me know if you want help doing that! |
Owner
|
I went ahead and did the rebase for you! |
adrn
reviewed
Aug 22, 2024
Owner
|
Thanks @ybillchen! |
Contributor
Author
|
Thank you Adrian! Super happy that this is merged to gala! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This branch implements the new Chen+24 (arXiv:2408.01496) model for stream modeling. A notebook demonstrating how to use the model is available.
-Bill Chen
Checklist
CHANGES.rst)