Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@TomWagg
Copy link
Contributor

@TomWagg TomWagg commented Sep 20, 2023

Describe your changes

I've added the same check that compute_coeffs has to compute_coeffs_discrete so that you get an error message rather than a list of zeros as your output if GSL_ENABLED is False.

I also added some warnings to the docstrings about the needs for GSL for these functions, obviously feel free to delete those.

Checklist

  • Did you add tests?
  • Did you add documentation for your changes?
  • Did you reference any relevant issues?
  • Did you add a changelog entry? (see CHANGES.rst)
  • Are the CI tests passing?
  • Is the milestone set?

@adrn adrn added this to the v1.8 milestone Sep 20, 2023
@adrn
Copy link
Owner

adrn commented Sep 20, 2023

Thanks for catching this! I'll merge when CI passes

@adrn adrn merged commit b1c8fa5 into adrn:main Sep 20, 2023
@TomWagg TomWagg deleted the scf-gsl-warnings branch September 20, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants