IO for SCF potentials #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@adrn unsure what to do with the failing test - it fails because GSL isn't installed (makes sense) but not sure how to tell it to skip that test - would it make sense to just check |
Owner
|
In the test file, you can do |
Contributor
Author
|
Cool! I knew you'd have a fancy method 🙃 It should be all set now! |
Owner
|
Thanks @TomWagg !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I tweaked the potential
__init__.pyso that it can find SCF potentials, which ensures that IO will work for them. I also added a test for this (hopefully in the right place/correctly) which passes for me now.Checklist
CHANGES.rst)