Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@adrn
Copy link
Owner

@adrn adrn commented Oct 20, 2025

Describe your changes

This PR addresses a few things left borked / open after adding the TimeInterpolatedPotential.

  • First, this fixes the way TimeInterpolatedPotential handles array-valued parameters (like Snlm in SCFPotential)
  • This also changes some deprecation warnings to future warnings and deprecates the SCFInterpolatedPotential
  • This also adds a list of unsupported potentials for TimeInterpolatedPotential that is now validated at initialization

Checklist

  • Did you add tests?
  • n/a Did you add documentation for your changes?
  • Did you reference any relevant issues?
  • n/a Did you add a changelog entry? (see CHANGES.rst)
  • Are the CI tests passing?
  • Is the milestone set?

@adrn adrn added this to the v1.11 milestone Oct 20, 2025
@adrn adrn force-pushed the time-interp-fix-array-params branch 2 times, most recently from 62ae6dd to 9d3d536 Compare October 23, 2025 17:14
@adrn adrn force-pushed the time-interp-fix-array-params branch from 9d3d536 to 6bc7db7 Compare October 28, 2025 15:26
@adrn adrn merged commit c4ceb5d into main Oct 28, 2025
25 checks passed
@adrn adrn deleted the time-interp-fix-array-params branch October 28, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants