exp: return nan instead of crashing the interpreter #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a stop-gap measure until we get proper error propagation working.
to appease ruff
adrn
reviewed
Jun 27, 2025
adrn
reviewed
Jun 27, 2025
Owner
adrn
left a comment
There was a problem hiding this comment.
LGTM apart from the one suggested minor changelog edit! Thanks
Co-authored-by: Adrian Price-Whelan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Catch EXP interpolator exceptions (usually caused by an out-of-bounds time) and return NAN. This at least avoids crashing the interpreter. Hopefully we'll be able to propagate the exception to Python instead soon.
Also update the
EXPPotentialdocs a bit.x-ref #423
Checklist
CHANGES.rst)