Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@adrn
Copy link
Owner

@adrn adrn commented Nov 5, 2025

Describe your changes

This adds some new benchmark tests that use pytest-codspeed and a CI workflow to run the benchmarks.

Checklist

  • n/a Did you add tests?
  • n/a Did you add documentation for your changes?
  • Did you reference any relevant issues?
  • n/a Did you add a changelog entry? (see CHANGES.rst)
  • Are the CI tests passing?
  • Is the milestone set?

@adrn adrn added this to the v1.11 milestone Nov 5, 2025
@adrn adrn added the benchmark label Nov 5, 2025
@adrn adrn requested a review from lgarrison November 5, 2025 15:02
@adrn
Copy link
Owner Author

adrn commented Nov 5, 2025

@lgarrison Do you have any thoughts about the technical implementation, or other ideas for important things to benchmark here? I'd be interested in discussing at some point! I'll probably add more benchmarks for all of the potential classes.

@adrn adrn added skip tests Skip the tests.yml pytest tests skip wheels labels Nov 5, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 5, 2025

@adrn adrn added the skip docs label Nov 5, 2025
@adrn adrn mentioned this pull request Nov 5, 2025
@lgarrison
Copy link
Collaborator

This is running on GH Actions runners right now, right? If those turn out to be too noisy, we could look into running this on Jenkins instead (unless we just want to use Codspeed runners).

@adrn
Copy link
Owner Author

adrn commented Nov 5, 2025

Noisy is one thing, but they're also super slow -- do you think they'd be faster via Jenkins?

@lgarrison
Copy link
Collaborator

lgarrison commented Nov 5, 2025

Potentially! Although the biggest gain on either Jenkins or GH Actions would probably be to run benchmarks in parallel (e.g. with a job matrix, https://codspeed.io/docs/benchmarks/python#running-benchmarks-in-parallel-ci-jobs).

@adrn
Copy link
Owner Author

adrn commented Nov 7, 2025

@lgarrison I'm going to give this a try with GH actions since the total test time is now reasonable for infrequent runs (~40 mins). Thanks for the tips! I'll let you know if I want to try switching to Jenkins at some point.

@adrn adrn changed the title [WIP] Add codspeed benchmarks Add codspeed benchmarks Nov 7, 2025
@adrn adrn merged commit 66d0f90 into main Nov 7, 2025
13 checks passed
@adrn adrn deleted the benchmarks branch November 7, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants