-
Notifications
You must be signed in to change notification settings - Fork 61
Add codspeed benchmarks #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@lgarrison Do you have any thoughts about the technical implementation, or other ideas for important things to benchmark here? I'd be interested in discussing at some point! I'll probably add more benchmarks for all of the potential classes. |
|
This is running on GH Actions runners right now, right? If those turn out to be too noisy, we could look into running this on Jenkins instead (unless we just want to use Codspeed runners). |
|
Noisy is one thing, but they're also super slow -- do you think they'd be faster via Jenkins? |
|
Potentially! Although the biggest gain on either Jenkins or GH Actions would probably be to run benchmarks in parallel (e.g. with a job matrix, https://codspeed.io/docs/benchmarks/python#running-benchmarks-in-parallel-ci-jobs). |
|
@lgarrison I'm going to give this a try with GH actions since the total test time is now reasonable for infrequent runs (~40 mins). Thanks for the tips! I'll let you know if I want to try switching to Jenkins at some point. |
Describe your changes
This adds some new benchmark tests that use pytest-codspeed and a CI workflow to run the benchmarks.
Checklist
CHANGES.rst)