Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update Client.php #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2020
Merged

Update Client.php #18

merged 2 commits into from
Jul 2, 2020

Conversation

@AlexNodex
Copy link
Contributor

Added source_ip as a config option

@AlexNodex
Update Client.php
98a72a5 
Added source_ip as a config option
@bakkerpeter
Copy link
Member

Thanks! I had to test it first since I'd expect the default to be null instead of 0.0.0.0 but this seems te be a PHP quirk. Works as expected.

@bakkerpeter bakkerpeter merged commit bfe86fd into afosto:master Jul 2, 2020
@bakkerpeter bakkerpeter mentioned this pull request Jul 2, 2020
Closed
@AlexNodex
Copy link
Contributor Author

null would set the device to null it's a libcurl quirk!

@bakkerpeter
Copy link
Member

My bad, thought I read somewhere it was PHP related, but your suggestion was right and I just merged it. Thanks again.

This was referenced May 7, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexNodex @bakkerpeter