Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Gemini client for function parameters with nested Pydantic schema #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 18, 2025
Merged

Fix Gemini client for function parameters with nested Pydantic schema #1002

merged 11 commits into from
Feb 18, 2025

Conversation

@rjambrecic
Copy link
Collaborator

@rjambrecic rjambrecic commented Feb 17, 2025 •
edited
Loading

Why are these changes needed?

  • Fix gemini with nested pydantic (BaseModel) function parameters
  • Add support for gemini with DeepResearchAgent
  • Fix gemini tests (a lot of gemini tests were skipped in the CI so we didn't know that some are failing)

Related issue number

Closes #984

Checks

@codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../tools/experimental/deep_research/deep_research.py 61.90% 8 Missing ⚠️
autogen/oai/gemini.py 92.30% 1 Missing ⚠️
Flag Coverage Δ
3.10 59.71% <48.71%> (+0.03%) ⬆️
3.11 57.26% <41.02%> (-1.36%) ⬇️
3.12 56.17% <41.02%> (+0.05%) ⬆️
3.13 59.29% <51.28%> (+0.03%) ⬆️
3.9 66.54% <74.35%> (+0.44%) ⬆️
anthropic 36.97% <41.02%> (-0.08%) ⬇️
autobuild ?
bedrock 15.94% <0.00%> (+<0.01%) ⬆️
browser-use 29.67% <48.71%> (-4.35%) ⬇️
cerebras 15.67% <0.00%> (+<0.01%) ⬆️
cohere 15.71% <0.00%> (+<0.01%) ⬆️
commsagent-discord 29.96% <41.02%> (-0.09%) ⬇️
commsagent-slack 29.95% <41.02%> (-0.09%) ⬇️
commsagent-telegram 29.90% <41.02%> (-0.09%) ⬇️
crawl4ai 29.69% <48.71%> (-3.64%) ⬇️
deepseek 31.96% <41.02%> (-0.28%) ⬇️
docs 28.69% <41.02%> (-0.07%) ⬇️
falkordb ?
gemini 39.32% <66.66%> (+0.41%) ⬆️
graph-rag-falkor-db 28.17% <41.02%> (-0.07%) ⬇️
groq 15.69% <0.00%> (+<0.01%) ⬆️
interop 29.56% <41.02%> (-4.01%) ⬇️
interop-crewai 28.93% <41.02%> (-0.07%) ⬇️
interop-langchain 28.76% <41.02%> (-0.07%) ⬇️
interop-pydantic-ai 29.28% <41.02%> (-0.07%) ⬇️
jupyter-executor 30.75% <41.02%> (-0.08%) ⬇️
lmm 18.38% <0.00%> (-0.46%) ⬇️
long-context 14.87% <0.00%> (+<0.01%) ⬆️
macos-latest 60.18% <51.28%> (+0.05%) ⬆️
mistral 15.41% <0.00%> (+<0.01%) ⬆️
neo4j ?
ollama 16.06% <0.00%> (+<0.01%) ⬆️
openai 44.03% <41.02%> (-0.07%) ⬇️
retrievechat 29.67% <41.02%> (-0.07%) ⬇️
retrievechat-couchbase 17.18% <0.00%> (+<0.01%) ⬆️
retrievechat-mongodb 29.66% <41.02%> (-0.07%) ⬇️
retrievechat-pgvector 29.66% <41.02%> (-0.07%) ⬇️
retrievechat-qdrant 29.61% <41.02%> (-0.07%) ⬇️
teachable 15.03% <0.00%> (-2.82%) ⬇️
together 15.73% <0.00%> (+<0.01%) ⬆️
twilio 28.39% <41.02%> (-0.07%) ⬇️
ubuntu-latest 67.77% <76.92%> (-0.09%) ⬇️
websurfer 17.83% <0.00%> (+0.01%) ⬆️
windows-latest 57.96% <51.28%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
autogen/agents/experimental/websurfer/websurfer.py 88.88% <100.00%> (-1.12%) ⬇️
autogen/oai/gemini.py 56.44% <92.30%> (+13.98%) ⬆️
.../tools/experimental/deep_research/deep_research.py 50.52% <61.90%> (-45.91%) ⬇️

... and 6 files with indirect coverage changes

@rjambrecic rjambrecic marked this pull request as draft February 17, 2025 14:00
@rjambrecic rjambrecic added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit 023d25b Feb 18, 2025
469 of 489 checks passed
@rjambrecic rjambrecic deleted the fix-gemini-client-with-nested-function-params branch February 18, 2025 12:12
@rjambrecic rjambrecic mentioned this pull request Feb 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davorrunje davorrunje davorrunje approved these changes

Assignees

@davorrunje davorrunje

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: DeepResearchAgent fails split_question_and_answer_subquestions method when using gemini model

3 participants

@rjambrecic @davorrunje