Pass system message as system_instruction to Gemini #1011. #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sonichi
reviewed
Feb 22, 2025
Collaborator
sonichi
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Thanks to this PR, I found some issues with the current documentation in https://docs.ag2.ai/docs/user-guide/models/google-gemini.
Co-authored-by: Chi Wang <[email protected]>
marklysze
approved these changes
Feb 26, 2025
Codecov ReportAttention: Patch coverage is
|
Collaborator
Author
Glad to have contributed to the project! Thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rjambrecic
Why are these changes needed?
Gemini supports system instructions. Sending the system_message as a system_instruction could potentially be more effective.
Related issue number
Fixes #1011
Checks