Thanks to visit codestin.com
Credit goes to github.com

Skip to content

In Memory query engine for DocAgent #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 27, 2025
Merged

In Memory query engine for DocAgent #1137

merged 5 commits into from
Feb 27, 2025

Conversation

@marklysze
Copy link
Collaborator

@marklysze marklysze commented Feb 25, 2025 •
edited
Loading

Why are these changes needed?

In the original plan for DocAgent, an in-memory option was to be included, allowing ingestion into the system prompt and then querying directly from that.

This PR creates an in memory query engine that stores ingested text into memory and runs queries from an internal agent's system prompt.

Related issue number

N/A

Checks

@marklysze marklysze self-assigned this Feb 25, 2025
@marklysze marklysze added the agents:docagent Document Agent label Feb 25, 2025
@marklysze
Copy link
Collaborator Author

marklysze commented Feb 26, 2025 •
edited
Loading

@AgentGenie and @Eric-Shang, please review when you get a chance, thanks! Changes to protocol and naming of classes:
DoclingMdQueryEngine to VectorChromaQueryEngine
VectorDbQueryEngine to RAGQueryEngine

Protocol simplified and aligned.

Names were just what I could think of, you may have better/more relevant names.

AgentGenie
AgentGenie reviewed Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@AgentGenie AgentGenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to keep all 4 methods from the protocol in autogen/agentchat/contrib/rag/query_engine.py because common vector db query engine will need those 4 methods.

inmemory query engine is a special case.
You can add init_db and connect_db methods in inmemory query engine and explicitly raise NotImplementedError to remind the user.

@marklysze
Copy link
Collaborator Author

marklysze commented Feb 27, 2025

I think it is good to keep all 4 methods from the protocol in autogen/agentchat/contrib/rag/query_engine.py because common vector db query engine will need those 4 methods.

inmemory query engine is a special case. You can add init_db and connect_db methods in inmemory query engine and explicitly raise NotImplementedError to remind the user.

I'll put back into protocol implement the NotImplementError exceptions... are you okay with naming changes?

@AgentGenie
Copy link
Collaborator

AgentGenie commented Feb 27, 2025

I'll put back into protocol implement the NotImplementError exceptions... are you okay with naming changes?
@marklysze Naming changes are good.

@AgentGenie AgentGenie marked this pull request as ready for review February 27, 2025 06:59
@davorrunje davorrunje added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit 1452c40 Feb 27, 2025
17 checks passed
@davorrunje davorrunje deleted the docagentinmemory branch February 27, 2025 08:53
@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 38.55422% with 51 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...perimental/document_agent/inmemory_query_engine.py 33.33% 46 Missing ⚠️
...imental/document_agent/docling_doc_ingest_agent.py 50.00% 2 Missing ⚠️
...ents/experimental/document_agent/document_agent.py 50.00% 2 Missing ⚠️
...agents/experimental/document_agent/parser_utils.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
autogen/agents/experimental/__init__.py 100.00% <100.00%> (ø)
...gen/agents/experimental/document_agent/__init__.py 100.00% <100.00%> (ø)
...experimental/document_agent/chroma_query_engine.py 34.14% <100.00%> (ø)
...agents/experimental/document_agent/parser_utils.py 27.27% <0.00%> (+0.15%) ⬆️
...imental/document_agent/docling_doc_ingest_agent.py 42.50% <50.00%> (+1.47%) ⬆️
...ents/experimental/document_agent/document_agent.py 31.93% <50.00%> (+0.30%) ⬆️
...perimental/document_agent/inmemory_query_engine.py 33.33% <33.33%> (ø)

... and 34 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AgentGenie AgentGenie AgentGenie left review comments

@davorrunje davorrunje davorrunje approved these changes

@Eric-Shang Eric-Shang Awaiting requested review from Eric-Shang

Assignees

@marklysze marklysze

Labels

agents:docagent Document Agent

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marklysze @AgentGenie @davorrunje